1472209 - Editing preferences makes about:welcome unresponsive

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Erica Wright [:ewright]]

STR:

navigate to `about:welcome`
click 'skip this step'
click the gear in the right corner
on the new tab it opens click on a box to change a preference
switch back to the about:welcome tab
interact with a tile or link on the page

AR:
the tile is unclickable, and the mouse remains as an arrow instead of a pointer

ER:
You can click and interact with links and tiles

Comment 1

[Ciprian Muresan [:cmuresan], Ecosystem QA]

It looks like the page also breaks when you reorder the sections, dismiss or follow the import flow, or acknowledge the Pocket disclaimer.

Comment 2

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Build ID 	20180701220749
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Adding that the page becomes unresponsive after continuing/dismissing the sign-in if you simply collapse a section. It seems this behavior was always this way ever since we implemented the about:welcome page.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4225

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/061c05f0037267d759188572a347f55292ee16c4
Fix Bug 1472209 - Remove StartupOverlay if the tour is skipped

Comment 5

[Ed Lee :Mardak]

This probably wants to be uplifted to 62? If so, we'll want the appropriate flags set

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Nightly build (63.0a1, Build ID 20180708220048) on Windows 10 x64, Mac 10.13.6 and Arch Linux x64.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Andrei, could you please fill the uplift request?
Thanks

Comment 8

[Andrei Oprea [:andreio]]

Attachment: Bug 1472209 - Remove StartupOverlay if the about:welcome tour is skipped.

Review commit: https://reviewboard.mozilla.org/r/255776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255776/

Comment 9

[Andrei Oprea [:andreio]]

Comment on attachment 8990691 [details]
Bug 1472209 - Remove StartupOverlay if the about:welcome tour is skipped.

Approval Request Comment
[Feature/Bug causing the regression]: The new about:welcome page
[User impact if declined]: Activity Stream will be unresponsive for users when they navigate from about:welcome
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Already verified 
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: small uplift that has been verified
[String changes made/needed]: n/a

Comment 10

[Ursula Sarracini (:ursula)]

Comment on attachment 8990691 [details]
Bug 1472209 - Remove StartupOverlay if the about:welcome tour is skipped.

https://reviewboard.mozilla.org/r/255776/#review262522

Previously reviewed on github, carrying the r+ here

Comment 11

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/c8abaff6bcae

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8990691 [details]
Bug 1472209 - Remove StartupOverlay if the about:welcome tour is skipped.

Verified in nightly, fix for regression in new about page.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Trying to import the mozreview patch on top of beta causes conflicts for install.rdf.in and the bundle file. Might be because bug 1472297 and bug 1470170 landed there. Please provide a patch which applies on beta.

Comment 14

[Ed Lee :Mardak]

andreio, this needs to land on our firefox-62 git branch first to generate the appropriate patch file.

Comment 15

[Andrei Oprea [:andreio]]

Comment on attachment 8990691 [details]
Bug 1472209 - Remove StartupOverlay if the about:welcome tour is skipped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/255776/diff/1-2/

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/34e9acac2e4b