Closed Bug 1472256 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 11732 - Update trivial IDL changes

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11732 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11732
Details from upstream follow.

Luke Bjerring <lukebjerring@chromium.org> wrote:
>  Update trivial IDL changes
>  
>  Updates all of the IDL files which are deemed to be trivial changes (whitespace-only, comments, etc).
>  ---
>  (See below for definition of "trivial" changes)
>  Hello reviewer(s),
>  
>  This PR is intended to consolidate the spec’s IDL definition with the WPT test suite’s copy, and any idlharness tests.
>  
>  The up-to-date copy of the IDL file was automatically extracted from the reffy-reports repo (https://github.com/tidoust/reffy-reports/tree/master/whatwg/idl) which scrapes known specs automatically + regulary.
>  
>  This PR is part of a migration project which will eventually be automatically updating and creating PRs for changes in spec IDL.
>  
>  Please check that:
>  The spec (and its source) is correct and up-to-date
>  All tests which cover the IDL in the spec have been migrated to fetch + use the idl in the `interfaces/` directory (instead of inline copies in the test files).
>  
>  Re: Trivial:
>  
>  This was achieved with:
>  
>      while read idl; do
>        git diff -s --exit-code master..origin/idl-file-updates-$idl -- interfaces/$idl.idl || {
>          DIFF=$(git --no-pager diff -U0 -w -B --diff-filter=M master..origin/idl-file-updates-$idl -- interfaces/$idl.idl)
>          CHANGED_LINES=$(echo "$DIFF" | grep '^[+-]' | grep -Ev '^(--- a/|\+\+\+ b/)')
>          NOT_BLANK_OR_COMMENTS=$(echo "$CHANGED_LINES" | grep -Ev '^[+-](//.*)?$')
>          if [[ "$NOT_BLANK_OR_COMMENTS" == "" ]]
>          then
>            echo $idl
>          fi
>        }
>      done <branches.txt
>  
>  Where branches.txt contains all of the spec names. Then,
>  
>      git checkout idl-file-updates-reffyreports-aggregated
>      while read idl; do
>        git checkout origin/idl-file-updates-$idl -- interfaces/$idl.idl
>      done <trivial.txt
>      git reset master
PR 11732 applied with additional changes from upstream: 418538eb1cce3ecd931285db697736aa2066d05c, 5ec42d40b2a49310976996ed6d0d316b82571a3f, 19c8f4488e2f2b2838b4890bfbf5c662a68616f2
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 27 tests and 694 subtests
OK     : 26
PASS   : 545
FAIL   : 149
TIMEOUT: 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d396738b9fbd
[wpt PR 11732] - Update trivial IDL changes, a=testonly
https://hg.mozilla.org/mozilla-central/rev/d396738b9fbd
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.