Open Bug 1472268 Opened Last year Updated Last year

VTune Integration Headers are out of date

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set

Tracking

()

ASSIGNED

People

(Reporter: bas.schouten, Assigned: bas.schouten, NeedInfo)

Details

Attachments

(1 file)

We should probably update them, even if there's not much difference. It may make merging easier later. I have patches.
Comment on attachment 8988805 [details]
Bug 1472268: Update in-tree VTune integration SDK.

https://reviewboard.mozilla.org/r/253978/#review260788
Attachment #8988805 - Flags: review?(sstangl) → review+
Pushed by bschouten@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e17f5abb8114
Update in-tree VTune integration SDK. r=sstangl
Backed out changeset e17f5abb8114 (bug 1472268) for build bustages on /src/js/src/vtune/ittnotify_static.c on a CLOSED TREE 

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/b1878bf341fcab452c4b63f608b66a4a761951df

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e17f5abb81144da115cfc6cefdff93f610913e8c

Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=185868027&repo=mozilla-inbound&lineNumber=3960

Log snippet: 

[task 2018-07-01T21:55:59.419Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/ffi'
[task 2018-07-01T21:55:59.419Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/ffi'
[task 2018-07-01T21:55:59.419Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/ffi'
[task 2018-07-01T21:55:59.419Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/mfbt'
[task 2018-07-01T21:55:59.419Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mfbt'
[task 2018-07-01T21:55:59.420Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/mfbt'
[task 2018-07-01T21:55:59.420Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/mfbt'
[task 2018-07-01T21:55:59.420Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/modules/zlib/src'
[task 2018-07-01T21:55:59.420Z] 21:55:59     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/gcc -m32 -march=pentium-m -std=gnu99 -o inffast.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -I/builds/worker/workspace/build/src/modules/zlib/src -I/builds/worker/workspace/build/src/obj-firefox/modules/zlib/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fno-omit-frame-pointer -Werror  -MD -MP -MF .deps/inffast.o.pp   /builds/worker/workspace/build/src/modules/zlib/src/inffast.c
[task 2018-07-01T21:55:59.420Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/modules/zlib/src'
[task 2018-07-01T21:55:59.420Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2018-07-01T21:55:59.421Z] 21:55:59     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/g++ -m32 -march=pentium-m -o bytestrie.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DU_COMMON_IMPLEMENTATION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DUCONFIG_NO_LEGACY_CONVERSION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_CHARSET_IS_UTF8 -DU_HAVE_NL_LANGINFO_CODESET=0 -I/builds/worker/workspace/build/src/config/external/icu/common -I/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common -I/builds/worker/workspace/build/src/intl/icu/source/i18n -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fno-omit-frame-pointer -Wno-deprecated-declarations -Wno-type-limits -Wno-unused-but-set-variable -Wno-unused-function -Wno-sign-compare -Wno-maybe-uninitialized -frtti  -MD -MP -MF .deps/bytestrie.o.pp   /builds/worker/workspace/build/src/intl/icu/source/common/bytestrie.cpp
[task 2018-07-01T21:55:59.422Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2018-07-01T21:55:59.422Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/modules/zlib/src'
[task 2018-07-01T21:55:59.422Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/modules/zlib/src'
[task 2018-07-01T21:55:59.422Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2018-07-01T21:55:59.422Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2018-07-01T21:55:59.422Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2018-07-01T21:55:59.422Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/common'
[task 2018-07-01T21:55:59.486Z] 21:55:59     INFO -  make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2018-07-01T21:55:59.487Z] 21:55:59     INFO -  /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/gcc/bin/gcc -m32 -march=pentium-m -std=gnu99 -o ittnotify_static.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DENABLE_BINARYDATA -DENABLE_SIMD -DENABLE_WASM_BULKMEM_OPS -DENABLE_WASM_SATURATING_TRUNC_OPS -DENABLE_WASM_THREAD_OPS -DENABLE_WASM_GC -DJS_CACHEIR_SPEW -DENABLE_SHARED_ARRAY_BUFFER -DEXPORT_JS_API -DJS_HAS_CTYPES '-DDLL_PREFIX="lib"' '-DDLL_SUFFIX=".so"' -DFFI_BUILDING -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/obj-firefox/js/src/ctypes/libffi/include -I/builds/worker/workspace/build/src/js/src/ctypes/libffi/src/x86 -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -DMOZILLA_CLIENT -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wduplicated-cond -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -freorder-blocks -O3 -fno-omit-frame-pointer -Werror  -MD -MP -MF .deps/ittnotify_static.o.pp  -Wno-varargs -Wno-unknown-pragmas /builds/worker/workspace/build/src/js/src/vtune/ittnotify_static.c
[task 2018-07-01T21:55:59.487Z] 21:55:59     INFO -  /builds/worker/workspace/build/src/js/src/vtune/ittnotify_static.c: In function '__itt_counter_create_init_3_0':
[task 2018-07-01T21:55:59.488Z] 21:55:59     INFO -  /builds/worker/workspace/build/src/js/src/vtune/ittnotify_static.c:534:42: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
[task 2018-07-01T21:55:59.488Z] 21:55:59     INFO -           if (h->nameA != NULL  && h->type == type && !__itt_fstrcmp(h->nameA, name) && ((h->domainA == NULL && domain == NULL) ||
[task 2018-07-01T21:55:59.489Z] 21:55:59     INFO -                                            ^~
[task 2018-07-01T21:55:59.489Z] 21:55:59     INFO -  /builds/worker/workspace/build/src/js/src/vtune/ittnotify_static.c: In function '__itt_counter_create_typed_init_3_0':
[task 2018-07-01T21:55:59.490Z] 21:55:59     INFO -  /builds/worker/workspace/build/src/js/src/vtune/ittnotify_static.c:609:42: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
[task 2018-07-01T21:55:59.490Z] 21:55:59     INFO -           if (h->nameA != NULL  && h->type == type && !__itt_fstrcmp(h->nameA, name) && ((h->domainA == NULL && domain == NULL) ||
[task 2018-07-01T21:55:59.490Z] 21:55:59     INFO -                                            ^~
[task 2018-07-01T21:55:59.491Z] 21:55:59     INFO -  cc1: all warnings being treated as errors
[task 2018-07-01T21:55:59.491Z] 21:55:59     INFO -  /builds/worker/workspace/build/src/config/rules.mk:753: recipe for target 'ittnotify_static.o' failed
[task 2018-07-01T21:55:59.491Z] 21:55:59     INFO -  make[4]: *** [ittnotify_static.o] Error 1
[task 2018-07-01T21:55:59.492Z] 21:55:59     INFO -  make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src'
[task 2018-07-01T21:55:59.492Z] 21:55:59     INFO -  make[4]: *** Waiting for unfinished jobs....
Flags: needinfo?(bas)
You need to log in before you can comment on or make changes to this bug.