1472421 - [FIX] nsRange should not use uncomposed doc

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: range_composed_with_test.diff

this needed a test
remote: View your change here:
remote:   https://hg.mozilla.org/try/rev/0fd9b64bac533ea5b400ae39333ea1c648342d50
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fd9b64bac533ea5b400ae39333ea1c648342d50
remote: recorded changegroup in replication log in 0.109s

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

could have passed function to the pushPrefEnv without the nameless function, in the test.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8989269 [details] [diff] [review]
range_composed_with_test.diff

Review of attachment 8989269 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/test/test_range_bounds.html
@@ +289,5 @@
>    isTransformed = true;
>    root.style.transform = "translate(30px,50px)";
>    doTest();
>  
> +  SpecialPowers.pushPrefEnv({"set":[["dom.webcomponents.shadowdom.enabled", true]]}, function() {

As you mentioned, you can pass `testShadowDOM` directly to pushPrefEnv but in the future, current JS style is to use `() => { ... }` for closures.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: range_composed_with_test_2.diff

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d12737168b1
nsRange should use composeddoc so that it works in shadow DOM, r=mrbkap

Comment 6

[Noemi Erli[:noemi_erli]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=2d12737168b11f9abd01461d2bd0a9c68bd2794a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=186203926

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=186203926&repo=mozilla-inbound

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/fdba9973982ab484d78323840e7e80c1a45bf093

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

oh, crap, should have called finish inside the callback.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Attachment: range_composed_with_test_3.diff

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/59874f1c664c
nsRange should use composeddoc so that it works in shadow DOM, r=mrbkap

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/59874f1c664c