Closed Bug 1472443 Opened Last year Closed Last year

Cleanup content properties a bit.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Just minor cleanups.
I'll happily take the review of whoever gets to it first :)

Most of it is automated by:

  %s/eStyleContentType_/StyleContentType::/g
  %s/nsStyleContentType/StyleContentType/g

But I removed some parentheses by hand.
... and cleanup unused keywords / getters using the scripts in
layout/style/tools
Comment on attachment 8988991 [details]
Serialize content properties using Servo.

Xidorn Quan [:xidorn] UTC+10 (less responsive until July 7) has approved the revision.

https://phabricator.services.mozilla.com/D1901
Attachment #8988991 - Flags: review+
Comment on attachment 8988990 [details]
Make StyleContentType an enum class.

Xidorn Quan [:xidorn] UTC+10 (less responsive until July 7) has approved the revision.

https://phabricator.services.mozilla.com/D1900
Attachment #8988990 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/bc6f59ccfb83
Make StyleContentType an enum class. r=xidorn
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/e86f35f8da45
Serialize content properties using Servo. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/bc6f59ccfb83
https://hg.mozilla.org/mozilla-central/rev/e86f35f8da45
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.