1472490 - [gn] Building webrtc busted on Linux aarch64 with sources included several times

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

The error looks like:

In file included from /<<PKGBUILDDIR>>/build-browser/media/webrtc/trunk/webrtc/common_audio/common_audio_c_gn/Unified_c_common_audio_c_gn0.c:47:0:
/<<PKGBUILDDIR>>/media/webrtc/trunk/webrtc/common_audio/signal_processing/complex_bit_reverse.c:20:22: error: redefinition of 'index_7'
 static const int16_t index_7[112] = {
                      ^~~~~~~
In file included from /<<PKGBUILDDIR>>/build-browser/media/webrtc/trunk/webrtc/common_audio/common_audio_c_gn/Unified_c_common_audio_c_gn0.c:38:0:
/<<PKGBUILDDIR>>/media/webrtc/trunk/webrtc/common_audio/signal_processing/complex_bit_reverse.c:20:22: note: previous definition of 'index_7' was here
 static const int16_t index_7[112] = {
                      ^~~~~~~

followed with more of the same pattern, the pattern being that there are multiple definitions of the same things from including the same source (complex_bit_reverse.c here) at two different places in Unified_c_common_audio_c_gn0.c.

That, in turn, is because media/webrtc/trunk/webrtc/common_audio/common_audio_c_gn/moz.build does this:

if CONFIG["OS_TARGET"] == "Linux":
    # ...
    UNIFIED_SOURCES += [
        "/media/webrtc/trunk/webrtc/common_audio/signal_processing/complex_bit_reverse.c",
        # ...
    ]

# ...

if CONFIG["CPU_ARCH"] == "aarch64":
    # ...
    UNIFIED_SOURCES += [
        "/media/webrtc/trunk/webrtc/common_audio/signal_processing/complex_bit_reverse.c",
        # ...
    ]

Note, we should probably make this a moz.build processing error.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

We would need to add a gn config for this combination for this to work as expected. Throwing an error is probably better in this case.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

(In reply to Chris Manchester (:chmanchester) from comment #1)
> We would need to add a gn config for this combination for this to work as
> expected. Throwing an error is probably better in this case.

The check passes automation, so I say we land it.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1472490 - Make adding a source to SOURCES, UNIFIED_SOURCES, or HOST_SOURCES multiple times an error in moz.build.

Review commit: https://reviewboard.mozilla.org/r/256992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256992/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8992106 [details]
Bug 1472490 - Make adding a source to SOURCES, UNIFIED_SOURCES, or HOST_SOURCES multiple times an error in moz.build.

https://reviewboard.mozilla.org/r/256992/#review263846

I thought the underlying data structure we used to hold SOURCES and friends performed a duplication check. But I guess I'm wrong.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b30d58d58f69
Make adding a source to SOURCES, UNIFIED_SOURCES, or HOST_SOURCES multiple times an error in moz.build. r=gps

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b30d58d58f69