Closed Bug 1472600 Opened 6 years ago Closed 6 years ago

Update SyncHandle when Tab is moved between windows

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

During looking into Bug 1452025 Comment 3, I noticed that SyncHandle was not updated when Tab was moved between windows.
Assignee: nobody → sotaro.ikeda.g
Blocks: 1452025
With attachment 8989109 [details] [diff] [review], WebRenderBridgeChild receives TextureFactoryIdentifier of moved window. TextureFactoryIdentifier has SyncHandle and KnowsCompositor::IdentifyTextureHost() creates an updated SyncObjectClient on windows.
 https://dxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/ShadowLayers.cpp#158
With attachment 8989109 [details] [diff] [review], Bug 1452025 was addressed for me.
Attachment #8989109 - Flags: review?(nical.bugzilla)
Attachment #8989109 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00da7e274896
Update SyncHandle when Tab is moved between windows r=nical
https://hg.mozilla.org/mozilla-central/rev/00da7e274896
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: