1472601 - Use EnsureInserted instead of Contains && PutEntry in EffectSet.cpp

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement, P5)

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1472601 - Use EnsureInserted to check a key in a hashtable and insert the key into the hashtable.

As for removing an entry, EnsureRemoved is equal to what Contains && RemoveEntry
do, but for consistency we use EnsureRemoved here.

Review commit: https://reviewboard.mozilla.org/r/254174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254174/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8989107 [details]
Bug 1472601 - Use EnsureInserted to check a key in a hashtable and insert the key into the hashtable.

I think Boris has empty request queue for now. :)

Comment 3

[Boris Chiou [:boris]]

Haha, I will review this soon. Cool, today is my onboard day in Portland. :)

Comment 4

[Boris Chiou [:boris]]

Oh, wait, the reviewer in mozreview is Brian, so should I review this patch?

Comment 5

[Hiroyuki Ikezoe (:hiro)]

yes please do!

Comment 6

[Boris Chiou [:boris]]

Comment on attachment 8989107 [details]
Bug 1472601 - Use EnsureInserted to check a key in a hashtable and insert the key into the hashtable.

https://reviewboard.mozilla.org/r/254174/#review261176

EnsureRemoved() is the combined of GetEntry() and RemoveEntry(), so this update looks good to me.
EnsureInserted() calls PutEntry() which "gets the entry associated with a key, or create a new entry", so if the entry exists, we just return the associated entry. If not, we create a new one. It looks like what we want in AddEffect().

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc9d3fbb1922
Use EnsureInserted to check a key in a hashtable and insert the key into the hashtable. r=boris

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/fc9d3fbb1922