Closed Bug 1472656 Opened 2 years ago Closed 2 years ago

TRR: make DNS_TRR_COMPARE only compare when in shadow mode

Categories

(Core :: Networking: DNS, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: bagder, Assigned: bagder)

Details

(Whiteboard: [necko-triaged][trr])

Attachments

(1 file)

... since having it done in TRRfirst etc as well makes it count failures in a bad way.
Comment on attachment 8989140 [details]
bug 1472656 - only do DNS_TRR_COMPARE in shadow or parallel mode

https://reviewboard.mozilla.org/r/254204/#review261026

SHADOW || PARALLEL ?
Attachment #8989140 - Flags: review?(mcmanus) → review-
Comment on attachment 8989140 [details]
bug 1472656 - only do DNS_TRR_COMPARE in shadow or parallel mode

https://reviewboard.mozilla.org/r/254204/#review261026

Ack!
Comment on attachment 8989140 [details]
bug 1472656 - only do DNS_TRR_COMPARE in shadow or parallel mode

https://reviewboard.mozilla.org/r/254204/#review261840
Attachment #8989140 - Flags: review?(mcmanus) → review+
Pushed by daniel@haxx.se:
https://hg.mozilla.org/integration/autoland/rev/e1ca34857660
only do DNS_TRR_COMPARE in shadow or parallel mode r=mcmanus
https://hg.mozilla.org/mozilla-central/rev/e1ca34857660
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.