1472659 - TRR: add Telemetry::DNS_TRR_FIRST to evaluate TRR-first and its fall-back

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Comment 1

[Daniel Stenberg [:bagder]]

... also adds a Telemetry::DNS_TRR_DISABLED boolean that counts success when called TRR-disabled when in TRR-first mode, which is used when doing a fallback from socket transport due to connection failure.

Comment 2

[Daniel Stenberg [:bagder]]

Attachment: bug 1472659 - add Telemetry::DNS_TRR_FIRST and Telemetry::DNS_TRR_DISABLED

To help evaluate TRRfirst sucess/error rates.

Review commit: https://reviewboard.mozilla.org/r/254212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254212/

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 8989146 [details]
bug 1472659 - add Telemetry::DNS_TRR_FIRST and Telemetry::DNS_TRR_DISABLED

https://reviewboard.mozilla.org/r/254212/#review261056

thanks for this. please make the histogram descriptions better.

Comment 4

[Daniel Stenberg [:bagder]]

Comment on attachment 8989146 [details]
bug 1472659 - add Telemetry::DNS_TRR_FIRST and Telemetry::DNS_TRR_DISABLED

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254212/diff/1-2/

Comment 5

[Daniel Stenberg [:bagder]]

Attachment: telemetry-dns_trr_first.txt

Request for data collection review: DNS_TRR_FIRST and DNS_TRR_DISABLED

Comment 6

[François Marier [:francois]]

Comment on attachment 8989382 [details]
telemetry-dns_trr_first.txt

> > List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the Mozilla wiki.
> 
> Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.
> Measurement Description 	Data Collection Category 	Tracking Bug #

I think you forgot to fill this part in. Can you please add this to the data review request so that it stands on its own?

    DNS_TRR_FIRST:
    RR-first mode distribution. 0=Worked, 1=fell back to native, 2=both failed
    Category 1

    DNS_TRR_DISABLED:
    Resolve success rate when in TRR-first and called TRR-disabled (fall-back mode)
    Category 1

I'll be happy to approve it once that's fixed.

Comment 7

[Daniel Stenberg [:bagder]]

Thanks, will amend.

Comment 8

[Daniel Stenberg [:bagder]]

Attachment: telemetry-dns_trr_first.txt

Request for data collection review: DNS_TRR_FIRST and DNS_TRR_DISABLED

Comment 9

[François Marier [:francois]]

Comment on attachment 8989687 [details]
telemetry-dns_trr_first.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes: Daniel Stenberg.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON in pre-release channels only.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eba17f3d25ef
add Telemetry::DNS_TRR_FIRST and Telemetry::DNS_TRR_DISABLED r=mcmanus

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/eba17f3d25ef