Closed
Bug 1472666
Opened 6 years ago
Closed 6 years ago
UniquePtr cleanup patch broke UbiNode.cpp compilation for Clang 3.6 - 3.8
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
|
1.65 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
See https://mozilla.logbot.info/developers/20180702#c14961566 Older Clangs (3.6 - 3.8) don't seem to support this UniquePtr constructor [1]. [1] https://searchfox.org/mozilla-central/rev/ed2763bea882619ccb48b0aecc54e523d2bdd2ae/mfbt/UniquePtr.h#274-286
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8989797 -
Flags: review?(jwalden+bmo)
|
||
Updated•6 years ago
|
Attachment #8989797 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b406e710db5a1f454b3adc6c80f86ebe3a404026
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a5edd04dc606 Fix UbiNode compilation for Clang 3.8 or older. r=Waldo
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a5edd04dc606
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•