Closed Bug 1472666 Opened 2 years ago Closed 2 years ago

UniquePtr cleanup patch broke UbiNode.cpp compilation for Clang 3.6 - 3.8

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file)

Attached patch bug1472666.patchSplinter Review
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8989797 - Flags: review?(jwalden+bmo)
Attachment #8989797 - Flags: review?(jwalden+bmo) → review+
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5edd04dc606
Fix UbiNode compilation for Clang 3.8 or older. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a5edd04dc606
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
See Also: → 1478942
You need to log in before you can comment on or make changes to this bug.