1472680 - Rename ClassifiedFailure and FailureClassification

Status: RESOLVED WONTFIX

(Tree Management :: Treeherder, enhancement, P3)

Description

[George Hickman]

These two models/tables cover different concepts in our data model but their names are confusingly similar.

FailureClassification is effectively an ENUM of failure types (intermittent, infra, etc).  It's used to define the type of failure for a Job (& JobNote).

ClassifiedFailure models a test failure, which can occur in one or more log lines.

This bug is to decide on how we rename and how in-depth that renaming is.

My suggestion for naming:
* FailureClassification -> FailureType
* ClassifiedFailure -> Classification

I feel this matches their usage in the data model and the nomenclature we use throughout the app.

and for how deep we go:

Rename the database tables on the basis that it's not an expensive migration.  This will reduce confusion for anyone else trying to understand the schema but I don't think it's necessarily worth closing the trees for.

Suggestons and comments appreciated!

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3794

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

cleaning up old bugs