Closed Bug 1472692 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11754 - Don't use six.string_types in wptserve.

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream error]) 

Sync web-platform-tests PR 11754 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11754
Details from upstream follow.

Ms2ger <Ms2ger@gmail.com> wrote:
>  Don't use six.string_types in wptserve.
>  
>  In python 2, it's defined as basestring, so it matches both str and unicode,
>  but in python 3, it matches only str (and not bytes). This does not seem like
>  a useful approach as we add python 3 support, and the now-passing tests
>  support that view.
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dd327dac2f2
[wpt PR 11754] - Don't use six.string_types in wptserve., a=testonly
https://hg.mozilla.org/mozilla-central/rev/1dd327dac2f2
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.