Closed
Bug 1472702
Opened 8 years ago
Closed 7 years ago
[wpt-sync] Sync PR 11755 - [LayoutNG] Support anonymous table cells natively.
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11755 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/11755
Details from upstream follow.
Morten Stenshorne <mstensho@chromium.org> wrote:
> [LayoutNG] Support anonymous table cells natively.
>
> Use LayoutObjectFactory when creating anonymous table cells, just
> like we already do for non-anonymous cells.
> We used to create legacy LayoutTableCell objects for anonymous cells,
> but allowed children to be NG. This was bad, since we should only
> switch engines at formatting context boundaries.
>
> One NG change was necessary here: Only anonymous *blocks* should
> inherit % resolution size. Anonymous table cells should NOT. This
> prevents fast/table/percent-height-inside-anonymous-cell.html from
> regressing.
>
> Two tests not related to tables regressed. Separate bugs reported.
> Some rebaselining was also necessary, since NG handles text runs and
> whitespace slightly differently.
>
> Added one test.
>
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Change-Id: Ibbb77073f1fbe1841ebf102c8bce440046f73319
>
> Reviewed-on: https://chromium-review.googlesource.com/1122218
> WPT-Export-Revision: 4441104aaef45ffc0b2e4abb4bc308511ae5b3f6
| Assignee | ||
Updated•8 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
| Assignee | ||
Comment 1•8 years ago
|
||
| Assignee | ||
Comment 2•8 years ago
|
||
| Assignee | ||
Comment 3•8 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=866d55416eb4faa4e9e469b37baa67fdaa0d63fb
| Assignee | ||
Comment 4•8 years ago
|
||
| Assignee | ||
Comment 5•8 years ago
|
||
| Assignee | ||
Comment 6•8 years ago
|
||
Ran 1 tests
PASS : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cea307dbb3ee
[wpt PR 11755] - [LayoutNG] Support anonymous table cells natively., a=testonly
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•