Closed Bug 1472777 Opened 6 years ago Closed 6 years ago

Implement a new 'create-interactive' action

Tracking

(firefox-esr60 fixed, firefox62 fixed, firefox63 fixed)

Status:

RESOLVED FIXED

Milestone:

mozilla63

Tracking Flags:

Tracking

Status

firefox-esr60

---

fixed

firefox62

---

fixed

firefox63

---

fixed

People

(Reporter: dustin, Assigned: dustin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1472777: add create-interactive action; 6 years ago Dustin J. Mitchell [:dustin] (he/him) 59 bytes, text/x-review-board-request	bstack : review+	Details

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Description

•

6 years ago

This can be generic for now.  We can make it more specific later.

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Updated

•

6 years ago

Summary: Implement a new 'create-interacgive' action → Implement a new 'create-interactive' action

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Comment 1

•

6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8899438001680fbe66bea4cf788a08769b5db2b4

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Comment 2

•

6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2a0c59d80eadd6a53f471a7edd8f603c11b240d9

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Comment 3

•

6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b99bf5a5ac2ee950e298874f0d54b2e54871399c

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Comment 4

•

6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85c85cd948836d14719cf1d3b09891822ed10f81

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Comment 5

•

6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1355cd33e935b7b13edbe0960d7fddd1d01f14c9

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Comment 6

•

6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd61113a1deb09158b3257c92b97eee485afd557

Comment hidden (mozreview-request)

The resulting action task isn't useful to the user, so instead we send an email
containing a link to the interaction console.

Review commit: https://reviewboard.mozilla.org/r/254352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254352/

Code Review Bot [:reviewbot]

Comment 8

•

6 years ago

mozreview-review

Comment on attachment 8989287 [details]
Bug 1472777: add create-interactive action;

https://reviewboard.mozilla.org/r/254352/#review261158


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: taskcluster/taskgraph/actions/util.py:127
(Diff revision 1)
>      task before it is put into a new graph. It should return a valid task. Note
>      that this is passed _all_ tasks in the graph, not just the set in to_run. You
>      may want to skip modifying tasks not in your to_run list.
>  
> -    If you wish to create the tasks in a new group, leave out decision_task_id."""
> +    If you wish to create the tasks in a new group, leave out decision_task_id.
> +    

Error: Blank line contains whitespace [flake8: W293]

Comment hidden (mozreview-request)

Comment on attachment 8989287 [details]
Bug 1472777: add create-interactive action;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254352/diff/1-2/

Brian Stack [:bstack]

Comment 10

•

6 years ago

mozreview-review

Comment on attachment 8989287 [details]
Bug 1472777: add create-interactive action;

https://reviewboard.mozilla.org/r/254352/#review261180

Other than the flake8 issue this looks great!

Attachment #8989287 - Flags: review?(bstack) → review+

Pulsebot

Comment 11

•

6 years ago

Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd9f1da21542
add create-interactive action; r=bstack

Pulsebot

Comment 12

•

6 years ago

Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/021b2f3683cf
Backed out 1 changesets for linting failures create_interactive.py CLOSED TREE

Andrei Ciure[:aciure]

Comment 13

•

6 years ago

Backed out 1 changesets (bug 1472777) for linting failures create_interactive.py

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fd9f1da215425382cf28cce5ce9c373fc803333d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=186095837&fromchange=a33b4bcf0a74497279cae6a3dbc61fa271051b28&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-searchStr=Linting+opt+source-test-mozlint-py-flake8+%28f8%29

log: https://treeherder.mozilla.org/logviewer.html#?job_id=186095837&repo=autoland

backout: https://hg.mozilla.org/integration/autoland/rev/021b2f3683cfa311166050cb84aff780fca60d73

Flags: needinfo?(dustin)

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Comment 14

•

6 years ago

mozreview-review-reply

Comment on attachment 8989287 [details]
Bug 1472777: add create-interactive action;

https://reviewboard.mozilla.org/r/254352/#review261180

So apparently "Code Review Bot" only shows you one linting failure.. there were many more after that!

TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/create_interactive.py:27:1 | expected 2 blank lines, found 1 (E302)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/create_interactive.py:45:100 | line too long (115 > 99 characters) (E501)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/create_interactive.py:61:5 | expected 1 blank line before a nested definition, found 0 (E306)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/create_interactive.py:79:100 | line too long (104 > 99 characters) (E501)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/create_interactive.py:93:100 | line too long (104 > 99 characters) (E501)
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/create_interactive.py:118:1 | blank line at end of file (W391)

Comment hidden (mozreview-request)

Comment on attachment 8989287 [details]
Bug 1472777: add create-interactive action;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254352/diff/2-3/

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Comment 16

•

6 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c2e0da78e763ddaa58733d0712c38ac10f7d696

Pulsebot

Comment 17

•

6 years ago

Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ea1193c44b9
add create-interactive action; r=bstack

Dustin J. Mitchell [:dustin] (he/him)

Assignee

Updated

•

6 years ago

Flags: needinfo?(dustin)

Stefan Hindli [:stefan_hindli]

Comment 18

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/2ea1193c44b9

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox63: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla63

Julien Cristau [:jcristau]

Comment 20

•

6 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-release/rev/2a09b5d4c6ae

status-firefox62: --- → fixed

Julien Cristau [:jcristau]

Comment 21

•

6 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-esr60/rev/98c58fda26d8

status-firefox-esr60: --- → fixed

Johan Lorenzo [:jlorenzo]

Updated

•

26 days ago

Blocks: 1754698

You need to log in before you can comment on or make changes to this bug.