Closed Bug 1472805 Opened 2 years ago Closed 2 years ago

silence more clang-cl warnings

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

clang seems to have decided that a new warning,
-Wused-but-marked-unused, is useful.  For the purposes of our codebase,
where we add __attribute__((unused)) explicitly to avoid warnings about
unused things, this new warning is useless.  The new warning is also
quite noisy, given that we have unused things in commonly-used headers
like Assertions.h.  So disable the warning.
Attachment #8989261 - Flags: review?(core-build-config-reviews)
Attachment #8989261 - Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9136af7a5017
silence more clang-cl warnings; r=chmanchester
https://hg.mozilla.org/mozilla-central/rev/9136af7a5017
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.