1472821 - Support array of String for lazyRequireGetter

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1465873, see Bug 1465873 comment 38:

(In reply to Brian Grinstead [:bgrins] from comment #38)
> Comment on attachment 8988174 [details]
> Bug 1465873 - part5: Move generic node utils from Node actor to layout/utils
> helper;
> 
> https://reviewboard.mozilla.org/r/253416/#review261070
> 
> ::: devtools/server/actors/inspector/node.js:19
> (Diff revision 3)
> >  
> >  loader.lazyRequireGetter(this, "getCssPath", "devtools/shared/inspector/css-logic", true);
> >  loader.lazyRequireGetter(this, "getXPath", "devtools/shared/inspector/css-logic", true);
> >  loader.lazyRequireGetter(this, "findCssSelector", "devtools/shared/inspector/css-logic", true);
> >  
> > +loader.lazyRequireGetter(this, "isAfterPseudoElement", "devtools/shared/layout/utils", true);
> 
> This makes me think we should update lazyRequireGetter to optionally take
> array of names as a second parameter (like
> XPCOMUtils.defineLazyScriptGetter).
>

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1472821 - Support array of String for lazyRequireGetter

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1472821 - Use array of properties to call lazyRequireGetter in inspector actors

Depends on D85268

To illustrate the added value of supporting arrays in lazyRequireGetter

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1472821 - Update linter to detect array of properties defined by lazyRequireGetter

Depends on D85268

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1472821 - Move webconsole fixture mapping for async-storage in requireHacker

Depends on D85269

Comment 5

[Julian Descottes [:jdescottes]]

Try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=66f16a41d748fc5c083f7799a71e46851ef1e1b9

Comment 6

[Julian Descottes [:jdescottes]]

new try https://treeherder.mozilla.org/#/jobs?repo=try&revision=57f5c6cb8591cfbdea14a2e3e3adb66bc8f93671&selectedTaskRun=KfVpNEHhTdOYW2c_7CsZ3g.0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cff2a1c92de
Support array of String for lazyRequireGetter r=nchevobbe,rcaliman
https://hg.mozilla.org/integration/autoland/rev/e94159a1c5cd
Update linter to detect array of properties defined by lazyRequireGetter r=Standard8
https://hg.mozilla.org/integration/autoland/rev/b8156d89e6bf
Use array of properties to call lazyRequireGetter in inspector actors r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/84b257d07031
Move webconsole fixture mapping for async-storage in requireHacker r=nchevobbe

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0cff2a1c92de
https://hg.mozilla.org/mozilla-central/rev/e94159a1c5cd
https://hg.mozilla.org/mozilla-central/rev/b8156d89e6bf
https://hg.mozilla.org/mozilla-central/rev/84b257d07031