1472829 - Add some use counters for document.open

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

We want to have use counters for the following things:

1)  Calls to the 2-arg version of document.open()
2)  Calls to that 2-arg version that pass "replace" as the second arg.

#1 can't be a webidl counter because we only want to count one overload.  The idea of #1 is to have a better context for understanding the numbers from #2 as a fraction of all document.open calls.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Add use counters for document.open

The idea is to count non-no-op document.open and to count how many times that's
done with the replace argument set to "replace".

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8989299 [details] [diff] [review]
Add use counters for document.open

>+// document.open information
>+custom DocumentOpen calls document.open in a way that creates a new Window
>+custom DocumentOpenReplace calls document.open in a way that creates a new Window and replaces the old history entry.
Nit, perhaps easier to understand if s/Window/Window object/
just to make it more clear that this isn't about the variant which opens new windows

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc6abadce397
Add use counters for document.open.  r=smaug

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8989299 [details] [diff] [review]
Add use counters for document.open

Approval Request Comment
[Feature/Bug causing the regression]: Not a regression.
[User impact if declined]: It will take us several more months to get this data,
   given the extra-long nightly cycle we have right now.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No, in that I don't have telemetry
   pings with this patch yet.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's adding two use counters, and the code
   changes are pretty safe.
[String changes made/needed]: None, unless we use UseCounters.conf for
   localization.

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bc6abadce397

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8989299 [details] [diff] [review]
Add use counters for document.open

Add telemetry counters, let's uplift for beta 7. 
bz, can you confirm this worked for you once beta 7 is out next week?

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/5db3df3d5a43