Status

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

Trunk
mozilla63
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

Per policy we can start requiring rust 1.27 two weeks after its stable release, which was June 21, which is this Thursday, July 5th.
Assignee

Comment 1

11 months ago
We may want to delay a few days to ensure bug 1447116 sticks, but I'll prepare a patch.
Assignee: nobody → cmanchester
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8989586 [details]
Bug 1472857 - Allow rustc 1.27 to build in automation for the sake of the base-toolchains build.

https://reviewboard.mozilla.org/r/254602/#review261528

::: toolkit/library/rust/shared/build.rs:15
(Diff revision 1)
>          println!("cargo:rustc-cfg=feature=\"oom_with_global_alloc\"");
>          bootstrap = true;
>      } else if ver >= Version::parse("1.28.0-alpha").unwrap() && ver < Version::parse("1.29.0").unwrap() {
>          println!("cargo:rustc-cfg=feature=\"oom_with_hook\"");
>          bootstrap = true;
> -    } else if std::env::var("MOZ_AUTOMATION").is_ok() {
> +    } else if std::env::var("MOZ_AUTOMATION").is_ok() && ver >= Version::parse("1.29.0").unwrap() {

make this 1.29.0-alpha. beta and nightly 1.29.0 would not match.
Attachment #8989586 - Flags: review?(mh+mozilla)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 7

11 months ago
mozreview-review
Comment on attachment 8989586 [details]
Bug 1472857 - Allow rustc 1.27 to build in automation for the sake of the base-toolchains build.

https://reviewboard.mozilla.org/r/254602/#review262100
Attachment #8989586 - Flags: review?(mh+mozilla) → review+

Comment 8

11 months ago
mozreview-review
Comment on attachment 8989587 [details]
Bug 1472857 - Require rustc 1.27 to build.

https://reviewboard.mozilla.org/r/254604/#review262102
Attachment #8989587 - Flags: review+
Attachment #8989587 - Flags: review?(core-build-config-reviews)

Comment 9

11 months ago
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1b14111a06d
Allow rustc 1.27 to build in automation for the sake of the base-toolchains build. r=glandium
https://hg.mozilla.org/integration/autoland/rev/f4f6234d143c
Require rustc 1.27 to build. r=glandium

Comment 10

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a1b14111a06d
https://hg.mozilla.org/mozilla-central/rev/f4f6234d143c
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.