Closed Bug 1472857 Opened 2 years ago Closed 2 years ago

Require rust 1.27

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(2 files)

Bug 1472857 - Allow rustc 1.27 to build in automation for the sake of the base-toolchains build.
59 bytes, text/x-review-board-request
glandium
: review+
Details
Bug 1472857 - Require rustc 1.27 to build.
59 bytes, text/x-review-board-request
glandium
: review+
Details 
Per policy we can start requiring rust 1.27 two weeks after its stable release, which was June 21, which is this Thursday, July 5th.
We may want to delay a few days to ensure bug 1447116 sticks, but I'll prepare a patch.
Assignee: nobody → cmanchester
Comment on attachment 8989586 [details]
Bug 1472857 - Allow rustc 1.27 to build in automation for the sake of the base-toolchains build.

https://reviewboard.mozilla.org/r/254602/#review261528

::: toolkit/library/rust/shared/build.rs:15
(Diff revision 1)
>          println!("cargo:rustc-cfg=feature=\"oom_with_global_alloc\"");
>          bootstrap = true;
>      } else if ver >= Version::parse("1.28.0-alpha").unwrap() && ver < Version::parse("1.29.0").unwrap() {
>          println!("cargo:rustc-cfg=feature=\"oom_with_hook\"");
>          bootstrap = true;
> -    } else if std::env::var("MOZ_AUTOMATION").is_ok() {
> +    } else if std::env::var("MOZ_AUTOMATION").is_ok() && ver >= Version::parse("1.29.0").unwrap() {

make this 1.29.0-alpha. beta and nightly 1.29.0 would not match.
Attachment #8989586 - Flags: review?(mh+mozilla)
Comment on attachment 8989586 [details]
Bug 1472857 - Allow rustc 1.27 to build in automation for the sake of the base-toolchains build.

https://reviewboard.mozilla.org/r/254602/#review262100
Attachment #8989586 - Flags: review?(mh+mozilla) → review+
Comment on attachment 8989587 [details]
Bug 1472857 - Require rustc 1.27 to build.

https://reviewboard.mozilla.org/r/254604/#review262102
Attachment #8989587 - Flags: review+
Attachment #8989587 - Flags: review?(core-build-config-reviews)
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1b14111a06d
Allow rustc 1.27 to build in automation for the sake of the base-toolchains build. r=glandium
https://hg.mozilla.org/integration/autoland/rev/f4f6234d143c
Require rustc 1.27 to build. r=glandium
https://hg.mozilla.org/mozilla-central/rev/a1b14111a06d
https://hg.mozilla.org/mozilla-central/rev/f4f6234d143c
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.