Closed
Bug 1472873
Opened 3 years ago
Closed 3 years ago
[wpt-sync] Sync PR 11760 - [LayoutNG] Fix hit test clipping by fragmented border with round corner
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11760 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/11760 Details from upstream follow. Xiaocheng Hu <xiaochengh@chromium.org> wrote: > [LayoutNG] Fix hit test clipping by fragmented border with round corner > > Current NG hit test code decides whether a hit test location is clipped > by rounded border by adding border radius to all four corners and then > compare with the hit test location. This is wrong if the box is > fragmented, where it may have only two or zero rounded corners. > > This patch changes HitTestClippedOutByBorder() to take the above into > consideration. By utilizing |border_edges_|, it can generate the > corrected rounded border to be hit tested. > > Test: This patch slightly modifies WPT > hit-test-inline-fragmentation-with-border-radius.html as a workaround > of some rounding issue, which is out of the scope of this patch. > > Bug: 855279, 859233 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I1e3193f9fc2d5e52ff53d6cb2fcc2a0ae2b3aa43 > Reviewed-on: https://chromium-review.googlesource.com/1123265 > WPT-Export-Revision: b444e7494815633b515bbccf7c3f5bd22995e8e8
Assignee | ||
Comment 1•3 years ago
|
||
PR 11760 applied with additional changes from upstream: 8213774aa68cc63a195b5d4b82a6ec5f8279e0b9
Assignee | ||
Updated•3 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee | ||
Comment 2•3 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e441d06328a750bc1675031f1b1d87934bceb0bd
Assignee | ||
Comment 3•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=59a5f255e5855bed9fd8389d6f97e8320b1e29c9
Assignee | ||
Comment 4•3 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=970f4c88bddeb8005b9ddea2c7df4f3f7fa75f66
Assignee | ||
Comment 5•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a9674de85c0313e63176cc4eecc4b4642f46def
Assignee | ||
Comment 6•3 years ago
|
||
Ran 1 tests and 36 subtests OK : 1 PASS : 36
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/ff5f2bc38d16 [wpt PR 11760] - [LayoutNG] Fix hit test clipping by fragmented border with round corner, a=testonly
Comment 8•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ff5f2bc38d16
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•