Closed Bug 1472894 Opened Last year Closed Last year

GL_ABORT_ON_ERROR: generated/test_2_conformance2__rendering__blitframebuffer-size-overflow.html

Categories

(Core :: Canvas: WebGL, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Whiteboard: gfx-noted)

Attachments

(2 files)

With the bug angle-63, ANGLE rejects likely overflow candidates for glBlitFramebuffer:
Specifically, ranges like [-1,INT32_MAX]
Comment on attachment 8989323 [details]
Bug 1472894 - Forbid too-large ranges in BlitFramebuffer. -

https://reviewboard.mozilla.org/r/254380/#review261822

looks reasonable
Attachment #8989323 - Flags: review?(kvark) → review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a7fd6321044
Forbid too-large ranges in BlitFramebuffer. - r=kvark
https://hg.mozilla.org/mozilla-central/rev/8a7fd6321044
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Bug 1472894 modified mochitest-errata.ini but didn't regenerate generated-mochitest.ini to actually un-skip the test_2_conformance2__rendering__blitframebuffer-size-overflow.html test.
Green Try run with the test_2_conformance2__rendering__blitframebuffer-size-overflow.html test unskipped:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e6f06e35bded55bf1408df2165b02df75bf44c1&selectedJob=200201322
Comment on attachment 9009841 [details]
Bug 1472894 - Part 2: Regenerate webgl-conf/generated-mochitest.ini. r?jgilbert

Jeff Gilbert [:jgilbert] has approved the revision.
Attachment #9009841 - Flags: review+
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a62a379ce69
Part 2: Regenerate webgl-conf/generated-mochitest.ini. r=jgilbert
You need to log in before you can comment on or make changes to this bug.