Closed Bug 1472904 Opened 6 years ago Closed 6 years ago

Move menu styling to a separate CSS file

Categories

(DevTools :: General, enhancement, P3)

Product:
DevTools
Component:
General
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: birtles, Assigned: mantaroh)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1472904 - Part 1. Add the common variable of tooltip and autopopup. r?jdescottes
46 bytes, text/x-phabricator-request
jdescottes
: review+
Details | Review
Bug 1472904 - Part 2. Move Tooltip variable to tooltips.css. r?jdescottes
46 bytes, text/x-phabricator-request
jdescottes
: review+
Details | Review 
While we're at it, let's move the variables for doorhangers to tooltips.css.
Priority: -- → P3
Ah, this doorhanger's variable is used by autocomplete popup as well at the moment.[1] (For detail, see the bug 1478435)
We need to add a new variable for autocomplete popup before separating this variable.

[1] https://searchfox.org/mozilla-central/search?q=theme-arrowpanel&case=false&regexp=false&path=
Before moving the tooltip's variable to tooltips.css, this patch will define
the common variable of tooltip and autopopup.
Comment on attachment 9003670 [details]
Bug 1472904 - Part 1. Add the common variable of tooltip and autopopup. r?jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9003670 - Flags: review+
Comment on attachment 9003671 [details]
Bug 1472904 - Part 2. Move Tooltip variable to tooltips.css. r?jdescottes

Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9003671 - Flags: review+
Attachment #9003670 - Attachment description: Bug 1472904 - Part 1. Add the common variable of tooltip and autopopup. r?birtles. → Bug 1472904 - Part 1. Add the common variable of tooltip and autopopup. r?jdescottes
Attachment #9003671 - Attachment description: Bug 1472904 - Part 2. Move Tooltip variable to tooltips.css. r?birtles → Bug 1472904 - Part 2. Move Tooltip variable to tooltips.css. r?jdescottes
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6da0f1618ac3
Part 1. Add the common variable of tooltip and autopopup. r=jdescottes
https://hg.mozilla.org/integration/mozilla-inbound/rev/04849dfc7b7e
Part 2. Move Tooltip variable to tooltips.css. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/6da0f1618ac3
https://hg.mozilla.org/mozilla-central/rev/04849dfc7b7e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: