Closed
Bug 1472931
Opened 6 years ago
Closed 6 years ago
Drop autofocus feature from HTMLTooltip
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: birtles, Assigned: mantaroh)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
Assignee | |
Comment 1•6 years ago
|
||
As Julian mentioned, this feature is no longer used.[1] So let's remove this property. Furthermore, we can drop the related test[2] as well. WIP: https://treeherder.mozilla.org/#/jobs?repo=try&revision=96eeb17d0339b794f60ab0e6722dc73527e9d025 [1] https://searchfox.org/mozilla-central/search?q=symbol:%23HTMLTooltip&redirect=false [2] https://searchfox.org/mozilla-central/rev/f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/client/shared/test/browser_html_tooltip-03.js
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
(In reply to Mantaroh Yoshinaga[:mantaroh] from comment #1) > As Julian mentioned, this feature is no longer used.[1] So let's remove this > property. > Furthermore, we can drop the related test[2] as well. > > WIP: > https://treeherder.mozilla.org/#/ > jobs?repo=try&revision=96eeb17d0339b794f60ab0e6722dc73527e9d025 > > > [1] > https://searchfox.org/mozilla-central/search?q=symbol: > %23HTMLTooltip&redirect=false > [2] > https://searchfox.org/mozilla-central/rev/ > f2ac80ab7dbde5400a3400d463e07331194dec94/devtools/client/shared/test/ > browser_html_tooltip-03.js Oh, I forgot to change the browser_toolbox_xul-wrapper.js. I confirmed that my local environment works well.
|
|
Assignee | |
Comment 3•6 years ago
|
||
This feature is no longer used. So this patch will remove this feature.
|
|
Assignee | |
Comment 4•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9003371 -
Attachment is obsolete: true
|
Reporter | |
Comment 5•6 years ago
|
||
Comment on attachment 9003370 [details] Bug 1472931 - Drop the autofocus feature of HTMLTooltip. r?birtles Brian Birtles (:birtles) has approved the revision.
Attachment #9003370 -
Flags: review+
|
|
||
Updated•6 years ago
|
Attachment #9003370 -
Attachment description: Bug 1472931 - Part 1. Drop the autofocus feature of HTMLTooltip. r?birtles → Bug 1472931 - Drop the autofocus feature of HTMLTooltip. r?birtles
Pushed by mantaroh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ba46bf160bdf Drop the autofocus feature of HTMLTooltip. r=birtles
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ba46bf160bdf
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•