1472951 - Remove ExternalImageId allocation for ImageClient

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

We do not need to allocate ExternalImageId for ImageClient. At WebRenderBridgeParent, ExternalImageId of TextureHost/TextureClient is actually used.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: wip

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove ExternalImageId allocation for ImageClient

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove ExternalImageId allocation for ImageClient

Remove unused variable.

Comment 4

[Sotaro Ikeda [:sotaro]]

attachment 8989686 [details] [diff] [review] removes ExternalImageId allocation for ImageClient. Instead, use ExternalImageId of TextureClient.

ExternalImageId of ImageClient is not actually used as ExternalImageId. WebRender uses ExternalImageId of TextureClient/TextureHost. WebRenderBridgeParent::AddExternalImage() converts ExternalImageId of ImageClient to ExternalImageId of TextureClient/TextureHost if possible.
  https://dxr.mozilla.org/mozilla-central/source/gfx/layers/wr/WebRenderBridgeParent.cpp#421

Then it becomes simpler if we just use ExternalImageId of TextureClient/TextureHost.

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d122302983911a157caa6daa1d2db2917150a7fa

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove ExternalImageId allocation for ImageClient

Update log.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Remove ExternalImageId allocation for ImageClient

Rebased.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aee8a4964b59
Remove ExternalImageId allocation for ImageClient r=nical

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/aee8a4964b59