Closed
Bug 1473000
Opened 6 years ago
Closed 6 years ago
Make test262-host.js a bit more resilient against changes to built-in functions
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
20.77 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
And change the |$test262.agent| functions, so we don't get called out here <https://github.com/tc39/test262/blob/ffdf41890874e7c5f4754e1aac25ab83c007684d/harness/atomicsHelper.js#L26-L28>. :-)
|
Assignee | |
Comment 1•6 years ago
|
||
Also removes the |this._bailIfNotAvailable()| calls when |sabTestable| is true (when |sabTestable| is false, this branch [1] is taken, which means [2] can never be true). [1] https://searchfox.org/mozilla-central/rev/403038737ba75af3842ba6b43b6e2fb47eb06609/js/src/tests/test262-host.js#62 [2] https://searchfox.org/mozilla-central/rev/403038737ba75af3842ba6b43b6e2fb47eb06609/js/src/tests/test262-host.js#147
Attachment #8989798 -
Flags: review?(jwalden+bmo)
|
||
Updated•6 years ago
|
Attachment #8989798 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b406e710db5a1f454b3adc6c80f86ebe3a404026
Keywords: checkin-needed
Pushed by shindli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fdd114ea8cfd Make test262-host more resilient against user code changes. r=Waldo
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fdd114ea8cfd
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•