1473144 - Run taskgraph tests with python 3

Status: RESOLVED DUPLICATE of bug 1638990

(Firefox Build System :: Task Configuration, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

2) Run your |mach python-test| tests under Python 3 in CI. The
first step is to remove the 'skip-if' annotation from the relevant
manifest:
https://searchfox.org/mozilla-central/search?q=skip-if.*python+%3F%3D%3D+%3F3&case=true&regexp=true&path=ini

Next, run |mach python-test <path/to/module> --python 3| and
fix any test failures that show up.

Finally, adjust the task (if applicable) to run with both python 2
and 3 by modifying this line in the appropriate task:
https://searchfox.org/mozilla-central/source/taskcluster/ci/source-test/python.yml#94

--

Once this is done, we *might* be able to run decision tasks in python 3?

Comment 1

[Gregory Szorc [:gps]]

I'm all for moving taskgraph code to Python 3. I think that's a worthwhile goal. It should result in some speedups. Especially once we can leverage asyncio for performing HTTP requests.

But I suspect the dependency chain is a bit long. For example, taskgraph pulls in some mozbuild modules. And things in mozbuild are generally not close to being Python 3 compatible.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Yeah, I'll try to accumulate the relevant blockers here as I find them..

Comment 3

[John Whitlock [:jwhitlock]]

I've filed issue #4614 on taskcluster to drop Python 2.7 support. Taskgraph might be the only Py2.7 user left. Is this a good tracking bug for the upgrade effort?

Comment 4

[Aki Sasaki (not active)]

Let's also port https://hg.mozilla.org/ci/taskgraph before we unblock https://github.com/taskcluster/taskcluster/issues/4614

Comment 5

[Andrew Halberstadt [:ahal]]

This bug was originally created for in-tree taskgraph (which has been running with Python 3 for awhile now). Though as Aki mentions, the out-of tree one still needs to be ported (hopefully this can largely be accomplished by upstreaming changes from in-tree).

Let's use bug 1700716 to track the out-of-tree taskgraph migration.