Closed Bug 1473169 Opened Last year Closed Last year

Support KHR_create_context_no_error

Categories

(Core :: Canvas: WebGL, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file)

We already made CreateContextFlags::NO_VALIDATION, so when we're already not expecting validation, we should tell the driver to not bother! (at least in non-debug cases)
Comment on attachment 8989591 [details]
Bug 1473169 - Support KHR_create_context_no_error in EGL. -

https://reviewboard.mozilla.org/r/254612/#review261826

one question, no blocking concerns

::: dom/canvas/WebGLContextDraw.cpp:754
(Diff revision 1)
>  
>      {
>          ScopedDrawCallWrapper wrapper(*this);
>          {
>              UniquePtr<gl::GLContext::LocalErrorScope> errorScope;
> -
> +            if (MOZ_UNLIKELY( gl->IsANGLE() &&

I assume it's unlikely because the Release mode isn't expected to abort on error, and we don't want to optimize for Debug?
Attachment #8989591 - Flags: review?(kvark) → review+
Comment on attachment 8989591 [details]
Bug 1473169 - Support KHR_create_context_no_error in EGL. -

https://reviewboard.mozilla.org/r/254612/#review261826

> I assume it's unlikely because the Release mode isn't expected to abort on error, and we don't want to optimize for Debug?

Yep, we're just trying to keep things on the happy path here. Probably not necessary, but I'd rather just have it.
Comment on attachment 8989591 [details]
Bug 1473169 - Support KHR_create_context_no_error in EGL. -

https://reviewboard.mozilla.org/r/254612/#review261960
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9cc2c931853b
Support KHR_create_context_no_error in EGL. - r=kvark
https://hg.mozilla.org/mozilla-central/rev/9cc2c931853b
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.