[a11y] Provide accessibility context for permission controls in identity popup

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P1
normal
RESOLVED FIXED
Last year
9 months ago

People

(Reporter: Jamie, Assigned: Jamie)

Tracking

({access})

Trunk
Firefox 63
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox61 wontfix, firefox62 fixed, firefox63 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

Last year
It's not really possible to provide STR for this because the permission controls in the identity popup aren't currently tabbable (bug 1473199). Once they are, though, a screen reader user tabbing through them won't know what they are for. For example, the user will just hear "Clear this permission and ask again  button", with no knowledge of what the permission is. This is because the label isn't associated in any semantic way with its button/menulist.

We can fix this by:
1. Applying an ARIA role of "group" to the permission containers; and
2. Using aria-labelledby to associate the labels with their elements.
Comment hidden (mozreview-request)

Comment 2

Last year
mozreview-review
Comment on attachment 8989623 [details]
Bug 1473200: Provide accessibility context for permission controls in the identity popup.

https://reviewboard.mozilla.org/r/254644/#review262006

Thank you!
Attachment #8989623 - Flags: review?(jhofmann) → review+
This is probably upliftable to 62 along with bug 1473199.
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee

Comment 4

Last year
(In reply to Johann Hofmann [:johannh] from comment #3)
> This is probably upliftable to 62 along with bug 1473199.

Note that this isn't a regression, but it's also a pretty low risk patch.

Comment 5

Last year
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13c926e66958
Provide accessibility context for permission controls in the identity popup. r=johannh

Comment 6

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/13c926e66958
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Assignee

Comment 7

11 months ago
Comment on attachment 8989623 [details]
Bug 1473200: Provide accessibility context for permission controls in the identity popup.

Approval Request Comment
[Feature/Bug causing the regression]: None.
[User impact if declined]: In the site identity pop-up, screen reader users will have difficulty identifying the permissions that can be adjusted, potentially leading to adjustment of the wrong permission.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: Bug 1473199.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Adds simple attributes that provide semantics for accessibility.
[String changes made/needed]: None.
Attachment #8989623 - Flags: approval-mozilla-beta?
Assignee

Updated

11 months ago
Depends on: 1473199
Comment on attachment 8989623 [details]
Bug 1473200: Provide accessibility context for permission controls in the identity popup.

A11y improvement to the identity UI, let's try it for beta 8.
Attachment #8989623 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.