1473220 - "Open in New Tab" under Developer Toolbar\Network doesn't send same content type

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[omid rad]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180627222831

Steps to reproduce:

It doesn't work properly if content type of the request is "application/json".

In my test case, I sent "{"email":"[e-mail]","password":"text&with&ampersand&in&it!"}" with "application/json" content type.

But when I open it in a new tab, it will send "application/x-www-form-urlencoded" content type which will be interpreted as:

{"email":"[e-mail]","password":"text
with
ampersand
in
it!"}

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1407515

@Tom: what could be the problem here?

Honza

Comment 2

[Tom Glowka]

Hey!

So the current implementation of this feature looks very basic, we do not use the content type of the original request when opening the new tab, but explicitly and unconditionally set "application/x-www-form-urlencoded" for any POST request. This is the exact line: https://hg.mozilla.org/mozilla-central/file/tip/devtools/client/netmonitor/src/utils/firefox/open-request-in-tab.js#l33

Maybe we should extend it to support more (any?) content types by utilizing content type from original request? Or at least support the "application/json" case, which this bug is about and seems to be most popular case.

I could take that bug as soon as I have new shape of this feature defined :)

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Tom Glowka from comment #2)
> Maybe we should extend it to support more (any?) content types by utilizing
> content type from original request?
Yes, I think this is the best way to go.

> I could take that bug as soon as I have new shape of this feature defined :)
Let me know if I should assign it to you.

Thanks,
Honza

Comment 4

[Tom Glowka]

(In reply to Jan Honza Odvarko [:Honza] from comment #3)

> Let me know if I should assign it to you.
I'll be happy to take it. Please do!

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Done, thanks for the help!
Honza

Comment 6

[Tom Glowka]

Attachment: Use original content-type when opening request in tab in Netmonitor

Before this change it was hardcoded to "application/x-www-form-urlencoded",
now original type is simply forwarded.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 9007099 [details]
Use original content-type when opening request in tab in Netmonitor

Jan Honza Odvarko [:Honza] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0661deed0ac4
Use original content-type when opening request in tab in Netmonitor r=Honza

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/0661deed0ac4