1473254 - AsyncConfigLoader could leak the Activity

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement)

Description

[Petru-Mugurel Lingurar [:petru]]

BrowserApp is passed to AsyncTaskLoader as Context [1].
This hard reference to it [2] could leak the activity until Switchboard.loadConfig(..) finishes [3], operation which in my tests finishes very quickly but nevertheless could be problematic.

[1] https://dxr.mozilla.org/mozilla-central/rev/a0e47ebc4c06e652b919dabee711fdbd6bfd31b5/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#752
[2] https://dxr.mozilla.org/mozilla-central/rev/a0e47ebc4c06e652b919dabee711fdbd6bfd31b5/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#1017
[3] https://dxr.mozilla.org/mozilla-central/rev/a0e47ebc4c06e652b919dabee711fdbd6bfd31b5/mobile/android/base/java/org/mozilla/gecko/switchboard/SwitchBoard.java#118

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.