1473262 - Force Marionette client to always use IPv4 to connect to Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Similar to bug 1462040 which was for geckodriver. Also Marionette client should be forced to use a IPv4 address by default for the connection.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1473262 - [marionette] Force client to always use IPv4 to connect to Marionette.

Marionette uses nsIServerSocket which only allows to create a IPv4 listener.
On systems where IPv6 has precedence Marionette client will automatically
use the IPv6 address for `localhost` and will fail to connect to Marionette.
As such we should make sure that Marionette client connects to "127.0.0.1"
by default.

Review commit: https://reviewboard.mozilla.org/r/254712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254712/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1473262 - [wptrunner] Use host 127.0.0.1 Marionette executor to connect to Marionette.

Review commit: https://reviewboard.mozilla.org/r/254714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254714/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8989699 [details]
Bug 1473262 - [marionette] Force client to always use IPv4 to connect to Marionette.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/254712/diff/1-2/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8989699 [details]
Bug 1473262 - [marionette] Force client to always use IPv4 to connect to Marionette.

https://reviewboard.mozilla.org/r/254712/#review261596

Comment 5

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8989724 [details]
Bug 1473262 - [wptrunner] Use host 127.0.0.1 Marionette executor to connect to Marionette.

https://reviewboard.mozilla.org/r/254714/#review261598

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53c113af0548
[marionette] Force client to always use IPv4 to connect to Marionette. r=ato
https://hg.mozilla.org/integration/autoland/rev/ea8d583affcb
[wptrunner] Use host 127.0.0.1 Marionette executor to connect to Marionette. r=ato

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/53c113af0548
https://hg.mozilla.org/mozilla-central/rev/ea8d583affcb

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/53c113af0548
https://hg.mozilla.org/mozilla-central/rev/ea8d583affcb

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11828 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged