Closed
Bug 1473263
Opened 7 years ago
Closed 7 years ago
Font editor: do not show font editor for nodes with zero used fonts
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(firefox63 verified, firefox64 verified)
VERIFIED
FIXED
Firefox 63
People
(Reporter: rcaliman, Assigned: rcaliman)
References
Details
Attachments
(2 files)
non-var font UI shows up for <head> element
Steps:
1. go to v-fonts.com
2. open DevTools, inspect the `<head>` element
3. select the Fonts panel
Expected:
No font editor and "No fonts found" message
Result:
Font Editor for non-variable fonts shows up and an empty list of used fonts, because none apply.
This case applies to any scenarios where the node is valid, but has no text content within its descendant nodes (i.e. empty nodes, `<script>`, `<img>`, etc)
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8989801 [details]
Bug 1473263 - Show "No fonts" message when there are no fonts used on the selected element or its descendants.
https://reviewboard.mozilla.org/r/254774/#review261780
Attachment #8989801 -
Flags: review?(pbrosset) → review+
| Comment hidden (mozreview-request) |
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71e47b1dfcd0
Show "No fonts" message when there are no fonts used on the selected element or its descendants. r=pbro
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
|
||
Updated•7 years ago
|
Flags: qe-verify+
QA Contact: catalin.sasca
|
||
Comment 6•7 years ago
|
||
I successfully reproduced the issue on Firefox Nightly 63.0a1 (2018-07-04) under Windows 10 (x64) using the STR from Comment 0.
The issue is no longer reproducible on Firefox Beta 63.0b12 and latest Nightly 64.0a1 (2018-10-07). Tests were performed under Windows 10 (x64), macOS 10.13, and Ubuntu 16.04 (x64).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
|
|
||
Updated•7 years ago
|
status-firefox64:
--- → verified
|
||
Updated•5 years ago
|
Component: Inspector: Fonts → Inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•