Closed Bug 1473265 Opened Last year Closed Last year

Print preview toolbar items should have distinct classes and ids

Categories

(Toolkit :: Printing, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Instead of this:

  toolbar[is="printpreview-toolbar"] .navigate-button {

We should just use .print-preview-navigate-button or something like that. Same for other classes and ids.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Comment on attachment 8990988 [details]
Bug 1473265 - Clean up print preview toolbar ids and classes.

https://reviewboard.mozilla.org/r/255994/#review262862

Thank you! Looks much better.
Attachment #8990988 - Flags: review?(bgrinstead) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/414ca83ed73f
Clean up print preview toolbar ids and classes. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/414ca83ed73f
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1501952
Regressions: 1576639
You need to log in before you can comment on or make changes to this bug.