Closed Bug 1473276 Opened 3 years ago Closed 3 years ago

Replace `which` with `command -v` for modern bash use

Categories

(Release Engineering :: Release Automation: Other, enhancement)

Product:
Release Engineering
Component:
Release Automation: Other
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr60 fixed, firefox63 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox63 --- fixed

People

(Reporter: sfraser, Assigned: sfraser)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1473276 'which' is non-standard, use 'command -v' in partials r=mtabara
46 bytes, text/x-phabricator-request
mtabara
: review+
Details | Review 
$ ./mach lint -l shellcheck
.../taskcluster/docker/funsize-update-generator/scripts/mbsdiff_hook.sh
  23:19  warning  which is non-standard. Use builtin 'command -v' instead.  2230 (shellcheck)
Assignee: nobody → sfraser
This will start to cause an error when a newer shellcheck is available in CI
Comment on attachment 8989709 [details]
Bug 1473276 'which' is non-standard, use 'command -v' in partials r=mtabara

Mihai Tabara [:mtabara]⌚️GMT has approved the revision.

https://phabricator.services.mozilla.com/D1940
Attachment #8989709 - Flags: review+
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e689eca8d98
'which' is non-standard, use 'command -v' in partials r=mtabara
https://hg.mozilla.org/mozilla-central/rev/1e689eca8d98
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.