1473287 - Treeherder jobs view fails to load if web notifications are unavailable (such as on iOS)

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Screen Shot 2018-07-04 at 8.22.42 AM.png

When visiting a front-page of Treeherder (https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound lets say) on an iPhone, I see the page load completely, then suddenly all the main content will disappear. 

This occurs both in Safari and in Firefox on iOS (iOS web view)

Comment 1

[Cameron Dawson [:camd]]

I'm able to reproduce this on my iphone.  While we don't officially support Treeherder on mobile, this seems like the very least one should expect to work.  I will see if I can figure out what is going on here and find a fix.

Comment 2

[Cameron Dawson [:camd]]

Matthew--  What kind of emulator did you use to get that screenshot?  Perhaps I could use it to debug this issue.  When I use responsive mode in Firefox desktop set to iphone, I can't reproduce.

Comment 3

[Matthew Gaudet (he/him) [:mgaudet]]

Regular ol' iPhone simulator: Open Xcode, then under the Xcode Menu, select Developer Tools -> Simulator

Thanks :D

Comment 4

[Junior [inactive]]

FWIW, When I close the preference "dom.webnotifications.enabled", the same issue happens to my firefox on mac os.

Comment 5

[Ed Morley [:emorley]]

Thank for that! Using the STR from comment 4, I see the following in the dev console:

ReferenceError: "Notification is not defined"

...in showUpdateNotifications():
https://github.com/mozilla/treeherder/blob/3ce79a93a74ab2bbfd041d7270fa30a2f6379590/ui/job-view/Push.jsx#L49

Guess it should really be checking for browser support first, a la the examples on the MDN page:
https://developer.mozilla.org/en-US/docs/Web/API/notification#Example

I think this also demonstrates that for any mobile-support type bugs filed, the console output is vital (and we should probably mark any that are missing it as "INCOMPLETE").

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3960

Comment 8

[Ed Morley [:emorley]]

Comment on attachment 9004360 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3960

Left a comment on the PR :-)

Comment 9

[Cameron Dawson [:camd]]

Comment on attachment 9004360 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3960

Made the requested changes.  :)

Comment 10

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f87f841e51daa2d6d850156b3a31a21c3fb89993
Bug 1473287 - Fix when Desktop notifications not supported (#3960)

Comment 11

[Jean-Yves Avenard [:jya]]

Sorry, but this is not fixed.
Opening https://treeherder.mozilla.org/#/jobs?repo=try&revision=860b4e649e7a168a54aa7e9e57fd6bbc9bf845c2 display the content for a very short amount of time and screen goes blank.

Tested with both safari and Firefox on iOS 11.4.1 on iPad Pro.

Comment 12

[Ed Morley [:emorley]]

Treeherder bugs are marked fixed when the PR merges to master. Deployment to stage (https://treeherder.allizom.org) then occurs automatically within 15 minutes, and to production when a manual push is made to the `production` branch (normally around once a week).

The currently deployed revision can be found via any of:
* In-app help menu -> "What's deployed" link
* Repo README (https://github.com/mozilla/treeherder) -> "What's Deployed" badge
* Wiki page (https://wiki.mozilla.org/EngineeringProductivity/Projects/Treeherder) -> "Deployed changes info"

This change hasn't yet been deployed to production, which is why you can still see the issue there. Could you try stage instead?

Comment 13

[Jean-Yves Avenard [:jya]]

When will this be pushed to prod?

Comment 14

[Ed Morley [:emorley]]

There was a prod push Friday, however it had to be rolled back due to a couple of regressions from other changes. We're keen to redeploy as soon as possible, which should be sometime this week.