Closed
Bug 1473297
Opened 6 years ago
Closed 6 years ago
Use inline elements for stack allocated binding name vectors in the parser
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
7.04 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
The parser uses vectors of BindingNames in a bunch of places when creating scope data. These use the default setting of zero inline elements, and therefore we have to malloc memory whenever we append to these vectors. Since these are stack based and used in functions that are not called recursively we should give these some inline elements to avoid this where possible.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8989741 -
Flags: review?(jwalden+bmo)
|
||
Updated•6 years ago
|
Attachment #8989741 -
Flags: review?(jwalden+bmo) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b8474706578c Use inline data for stack allocated binding name vectors in the parser r=Waldo
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b8474706578c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•