1473305 - Move browser_jsterm_popup.js near Autocomplete Popup code

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

This test directly calls Autocomplete popup inner method and only uses the console for the autocomplete popup instance and the input it offers (See [1]).

Let's move the test closer to the AutoComplete popup code


[1] https://searchfox.org/mozilla-central/rev/403038737ba75af3842ba6b43b6e2fb47eb06609/devtools/client/webconsole/test/mochitest/browser_jsterm_popup.js#29

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Blocking Bug 1463674 on this since it blocks the test migration that is done there.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1473305 - Move browser_jsterm_popup.js to devtools/client/shared/test ;.

This test is directly calling Autocomplete popup methods and only uses the
console for the instance and the input it provides. This patch moves the
test to the shared component folder, where the autocompletion code lives
so it feels more natural.
A few test cases are added in the jsterm_accessibility test, this time in
direct relation with the console input.

Review commit: https://reviewboard.mozilla.org/r/254752/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/254752/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8989753 [details]
Bug 1473305 - Move browser_jsterm_popup.js to devtools/client/shared/test ;.

https://reviewboard.mozilla.org/r/254752/#review261804

Looks reasonable to me.

R+

Thanks Nicolas!
Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bc3f36982ec
Move browser_jsterm_popup.js to devtools/client/shared/test ;r=Honza.

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5bc3f36982ec