Closed
Bug 1473309
Opened 6 years ago
Closed 6 years ago
Move TabContextMenu and stray usercontext-related functions from browser.js to tabbrowser.js
Categories
(Firefox :: Tabbed Browser, enhancement, P3)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•6 years ago
|
||
mozreview-review |
Comment on attachment 8989767 [details] Bug 1473309 - Move TabContextMenu and stray usercontext-related functions from browser.js to tabbrowser.js. https://reviewboard.mozilla.org/r/254756/#review262234 Makes sense. I see there are some slight changes to reopenInContainer and inlining updateTabMenuUserContextUIVisibility. As long as the behavior hasn't changed it's OK to do as part of the move. Otherwise please split it out into multiple changesets.
Attachment #8989767 -
Flags: review?(bgrinstead) → review+
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0ae959508fb1 Move TabContextMenu and stray usercontext-related functions from browser.js to tabbrowser.js. r=bgrins
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0ae959508fb1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•