1473382 - Ensure the mirror correctly fires change notifications for livemark annos

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Lina Butler [:lina]]

We're slowly removing annotations, but, in the meantime, errors like this (seen in the logs in bug 1472963) only add noise:

> 1529394434486	Sync.Engine.Bookmarks.Mirror	WARN	Error notifying observer: [Exception... "Not enough arguments [nsIAnnotationObserver.onItemAnnotationSet]"  nsresult: "0x80570001 (NS_ERROR_XPC_NOT_ENOUGH_ARGS)"  location: "JS frame :: resource://gre/modules/SyncedBookmarksMirror.jsm :: notifyObserver :: line 4659"  data: no] Stack trace: notifyObserver()@resource://gre/modules/SyncedBookmarksMirror.jsm:4659

This also means we don't have test coverage for `onItemAnnotation{Set, Removed}` observers. :-)

Comment 1

[Lina Butler [:lina]]

Turns out we don't fire `onItemChanged` notifications for annos, either. Oops. >.<

We're slowly removing annos from Places, anyway, but livemarks still use them, so the mirror should try to do the right thing for now.

Comment 2

[Lina Butler [:lina]]

Attachment: Ensure the bookmarks mirror fires item change observer notifications for livemark annos.

Comment 3

[Lina Butler [:lina]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b94e3c6b434faa7850ec85b5f596104fd77876f3

Comment 4

[Phabricator Automation]

Comment on attachment 8989889 [details]
Ensure the bookmarks mirror fires item change observer notifications for livemark annos.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D1962

Comment 5

[Lina Butler [:lina]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a740e95668cf0ebee033d4832fb03ed328fc28e5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b75dda634bc
Ensure the bookmarks mirror fires item change observer notifications for livemark annos. r=mak

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c8e9cc23b1d
Backed out changeset 4b75dda634bc for presumed ES lint failures on request of lin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d206108bb4c
Ensure the bookmarks mirror fires item change observer notifications for livemark annos. r=mak

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9d206108bb4c