Closed Bug 1473389 Opened 6 years ago Closed 6 years ago

Port raptor-speedometer to google chrome (chromium) on win7/win10/osx/linux64

Categories

(Testing :: Raptor, defect)

Product:
Testing
Component:
Raptor
Version:
Version 3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: rwood, Assigned: rwood)

References

Details

Attachments

(1 file)

Bug 1473389 - Port raptor-speedometer to google chrome (chromium) on win7/win10/osx/linux64;
59 bytes, text/x-review-board-request
jmaher
: review+
Details 
      No description provided.
Assignee: nobody → rwood
Status: NEW → ASSIGNED
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d02e0a7b24fe161139f1a7f9af18e677b0c6cde

Update: Got a green raptor speedometer run using a chromium build from google's CI. I'm going to switch over linux and osx to also use the same chromium build source, so that it is consistent. It isn't the google chrome browser itself - but chromium comes in a zip which we can easily install in our CI. Also note that AWFY uses chormium also and not actual google chrome.
Summary: Port raptor-speedometer google chrome to win7/10 → Port raptor-speedometer to google chrome (chromium) on win7/win10/osx/linux64
Comment on attachment 8990442 [details]
Bug 1473389 - Port raptor-speedometer to google chrome (chromium) on win7/win10/osx/linux64;

https://reviewboard.mozilla.org/r/255520/#review264448

a small nit

::: testing/mozharness/mozharness/mozilla/testing/raptor.py:173
(Diff revision 13)
>          self.chrome_dest = os.path.join(here, 'chrome')
>  
>          # mozharness/base/script.py.self.platform_name will return one of:
>          # 'linux64', 'linux', 'macosx', 'win64', 'win32'
>  
> +        base_url = "http://commondatastorage.googleapis.com/chromium-browser-snapshots"

add a comment and bug here for making this a fetch task :)

::: testing/mozharness/mozharness/mozilla/testing/raptor.py:187
(Diff revision 13)
> +                                            'Contents', 'MacOS', 'Chromium')
>  
>          elif 'linux' in self.platform_name():
> -            chrome_archive_file = "google-chrome-stable_current_amd64.deb"
> -            chrome_url = "https://dl.google.com/linux/direct/%s" % chrome_archive_file
> -            self.chrome_path = os.path.join(self.chrome_dest, 'opt', 'google',
> +            # for now hardcoding a revision; but change this to update to newer version; from:
> +            # http://commondatastorage.googleapis.com/chromium-browser-snapshots/Linux_x64/LAST_CHANGE
> +            chromium_rev = "575640"

why are these revisions different?

::: testing/mozharness/mozharness/mozilla/testing/raptor.py
(Diff revision 13)
> -                            '-C', self.chrome_dest])
> -
> -        else:
> -            # TODO: Bug 1473389 - finish this for windows 7 (x32) and winows 10 (x64)
> -            pass
> -

this big code removal is excellent
Attachment #8990442 - Flags: review?(jmaher) → review+
Comment on attachment 8990442 [details]
Bug 1473389 - Port raptor-speedometer to google chrome (chromium) on win7/win10/osx/linux64;

https://reviewboard.mozilla.org/r/255520/#review264448

> add a comment and bug here for making this a fetch task :)

Thanks for the review. Good point, added comment and filed Bug 1476372.

> why are these revisions different?

Unfortunately on the chromium build site they don't use the same revision for all of the platforms, the revision numbers are platform specific.
Comment 28 is this patch - raptor speedometer on chromium on all platforms.

Joel, FYI - as you suggested I also did a push to try on osx/linux of raptor speedometer on google chrome itself (as I had the actual google chrome install working on osx/linux but NOT windows) [1].

Comparing running raptor speedometer on google chrome vs chromium the numbers aren't too far off:

Google Chrome OSX: 51.29, 53.04, 52.63, 52, 52.75, 51.57.
Chromium OSX: 50.11, 50.26, 48.93, 49.01, 49.78, 50.63.

Google Chrome linux64: 41.28, 41.58, 39.68, 39.8, 39.32, 39.92.
Chromium linux64: 39.11, 37.92, 38.69, 36.82, 36.25, 37.25.

Since AWFY uses chromium and also it's possible to install chromium easily in our CI on all platforms (it's a simple zip) we should just go ahead with chromium.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=9529783ba343b8332119783add9d407d928415ef&filter-tier=1&filter-tier=2&filter-tier=3
Flags: needinfo?(jmaher)
it looks like a ~3% regression we will hit, but since AWFY uses Chromium, we should use that as well.  Lets move forward.
Flags: needinfo?(jmaher)
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0585180a0c3
Port raptor-speedometer to google chrome (chromium) on win7/win10/osx/linux64; r=jmaher
https://hg.mozilla.org/mozilla-central/rev/c0585180a0c3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: