Closed Bug 1473424 Opened 5 years ago Closed 5 years ago

Port Bug 1382635 "FormDataListener shouldn't listen for change events" to SeaMonkey

Categories

(SeaMonkey :: Session Restore, enhancement)

Product:
SeaMonkey
Component:
Session Restore
Version:
SeaMonkey 2.53 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr unaffected, seamonkey2.60 fixed, seamonkey2.53 affected, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.60
Tracking Flags:
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.60 --- fixed
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file, 1 obsolete file)

1473424-formdatalistener.patch
8.81 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review 
From bug 1382635:

As already mentioned by Ehsan in bug 1373672 comment #0, the FormDataListener listens for both change and input events, based on a decision made long before we imported the add-on code into Firefox.

AFAICT whenever the user interacts with a form element we dispatch the "input" event properly, I couldn't find a counterexample. In the past (Firefox 2 and before) we might have had inconsistent behavior.
Attached patch 1473424-formdatalistener.patch (obsolete) — — Splinter Review 

        Attachment #8989950 -
        Flags: review?(iann_bugzilla)

        Attachment #8989950 -
        Flags: approval-comm-esr60?

    
    

    
  


  
A patch which actually applies to the current trees and not only to 2.53

        Attachment #8989950 -
        Attachment is obsolete: true

        Attachment #8989950 -
        Flags: review?(iann_bugzilla)

        Attachment #8989950 -
        Flags: approval-comm-esr60?

        Attachment #8990071 -
        Flags: review?(iann_bugzilla)

        Attachment #8990071 -
        Flags: approval-comm-esr60?

    
    

    
  
Comment on attachment 8990071 [details] [diff] [review]
1473424-formdatalistener.patch

LGTM r/a=me

        Attachment #8990071 -
        Flags: review?(iann_bugzilla)

        Attachment #8990071 -
        Flags: review+

        Attachment #8990071 -
        Flags: approval-comm-esr60?

        Attachment #8990071 -
        Flags: approval-comm-esr60+

    
    

    
  
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6e08b6e36bd5
Port Bug 1382635 [FormDataListener shouldn't listen for change events] to SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.