Closed Bug 1473424 Opened Last year Closed Last year

Port Bug 1382635 "FormDataListener shouldn't listen for change events" to SeaMonkey

Categories

(SeaMonkey :: Session Restore, enhancement)

SeaMonkey 2.53 Branch
enhancement
Not set

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53 affected, seamonkey2.57esr fixed, seamonkey2.60 fixed)

RESOLVED FIXED
seamonkey2.60
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed
seamonkey2.60 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file, 1 obsolete file)

From bug 1382635:

As already mentioned by Ehsan in bug 1373672 comment #0, the FormDataListener listens for both change and input events, based on a decision made long before we imported the add-on code into Firefox.

AFAICT whenever the user interacts with a form element we dispatch the "input" event properly, I couldn't find a counterexample. In the past (Firefox 2 and before) we might have had inconsistent behavior.
Attached patch 1473424-formdatalistener.patch (obsolete) — Splinter Review
Attachment #8989950 - Flags: review?(iann_bugzilla)
Attachment #8989950 - Flags: approval-comm-esr60?
A patch which actually applies to the current trees and not only to 2.53
Attachment #8989950 - Attachment is obsolete: true
Attachment #8989950 - Flags: review?(iann_bugzilla)
Attachment #8989950 - Flags: approval-comm-esr60?
Attachment #8990071 - Flags: review?(iann_bugzilla)
Attachment #8990071 - Flags: approval-comm-esr60?
Comment on attachment 8990071 [details] [diff] [review]
1473424-formdatalistener.patch

LGTM r/a=me
Attachment #8990071 - Flags: review?(iann_bugzilla)
Attachment #8990071 - Flags: review+
Attachment #8990071 - Flags: approval-comm-esr60?
Attachment #8990071 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/6e08b6e36bd5
Port Bug 1382635 [FormDataListener shouldn't listen for change events] to SeaMonkey. r=IanN
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.