We need to be able to tell which button is the "Cancel" action for Windows "X" ind dialogs

VERIFIED FIXED in M16

Status

SeaMonkey
UI Design
P2
critical
VERIFIED FIXED
18 years ago
13 years ago

People

(Reporter: Charles Manske, Assigned: davidm)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
In the nsICommonDialogs interface, we need to be able to map the "Cancel"
action, which is what should happen when a Window's user click's on the
"X" button on the window caption, to a specific button.
This is related to solving the platform-specific button order problem for
dialogs such as:
[Save] [Don't Save] [Cancel] (Windows, UNIX ordering)
[Save] [Cancel]  [Don't Save](Mac ordering)
Currently, clicking on the "X" always maps to the 2nd button, which is wrong
for Windows/UNIX button order.
(Reporter)

Updated

18 years ago
Blocks: 14719
(Assignee)

Comment 1

18 years ago
No you don't. What you need to do is modify the platform specific XUL so that
the button order is
	[ Confirm] [other ] [Abort]
rather than
	[ Confirm] [Abort] [ Other]

Updated

18 years ago
Component: XP Toolkit/Widgets → XPApps
Priority: P3 → P2
Target Milestone: M11

Comment 2

18 years ago
David, so is this our bug or Charlie's bug?  If it's not ours then re-assign it
back to him or possibly help him fix it.
(Assignee)

Updated

18 years ago
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → INVALID
(Assignee)

Comment 3

18 years ago
marking invalid although I might have to modify the JS to hide a box around a
button rather than the button but that is a UI clenan up issue for right before
UI freeze.
(Reporter)

Updated

18 years ago
Status: RESOLVED → REOPENED
(Reporter)

Comment 4

18 years ago
This is not invalid. As David pointed out, we need to modify the existing
platform-specific XUL files. Has that been done yet?

Currently there is only one: platformDialogOverlay.xul. Here are the buttons:
	<!-- OK & Cancel Buttons -->
	 <box id="okCancelButtons" align="horizontal" style="margin-top: 0.5em">
		<spring flex="100%"/>
		<!-- centering offset for two 10px springs that are not hidden
-->
		<spring style="width:20px"/>
		<titledbutton id="ok" value="&okButton.label;" default="true"
align="right" onclick="doOKButton()"/>
		<spring style="width:10px"/>
		<titledbutton id="cancel" value="&cancelButton.label;"
onclick="doCancelButton()"/>
		<spring style="width:10px"/>
		<titledbutton id="Button2" value="&cancelButton.label;" style =
"display:none;" onclick="doButton2()"/>
		<spring style="width:10px"/>
		<titledbutton id="Button3" value="&cancelButton.label;" style =
"display:none;" onclick="doButton3()"/>
		<spring flex="100%"/>
	</box>
To make this display correctly on Windows, it should be something like:

	<!-- OK & Cancel Buttons -->
	 <box id="okCancelButtons" align="horizontal" style="margin-top: 0.5em">
		<spring flex="100%"/>
		<!-- centering offset for two 10px springs that are not hidden
-->
		<spring style="width:20px"/>
		<titledbutton id="ok" value="&okButton.label;" default="true"
align="right" onclick="doOKButton()"/>
		<spring style="width:10px"/>
		<titledbutton id="Button2" value="&cancelButton.label;" style =
"display:none;" onclick="doButton2()"/>
		<spring style="width:10px"/>
		<titledbutton id="Button3" value="&cancelButton.label;" style =
"display:none;" onclick="doButton3()"/>
		<spring flex="100%"/>
		<titledbutton id="cancel" value="&cancelButton.label;"
onclick="doCancelButton()"/>
		<spring style="width:10px"/>
	</box>

This puts the Cancel button in the right corner. Then there needs to be
the Mac version. I'm not sure if this is exactly correct for all cases
in the browser or mail that use this "common dialog".
These are not "my" dialogs, so I'm hesitant to fix them.
(Assignee)

Updated

18 years ago
Target Milestone: M11 → M16
(Assignee)

Comment 5

18 years ago
Whatever. m16 when UI cleanup should be done.

Updated

18 years ago
Resolution: INVALID → ---

Updated

18 years ago
QA Contact: beppe → cpratt

Comment 6

18 years ago
clearing the resolution since this is not an ivalid bug
(Reporter)

Comment 7

18 years ago
Ok, so I did some more investigating and realize that there is a correct Mac
version for this, so can I just checkin the window's version to move Cancel
to the right location? If yes, just reassign the bug to me.
(Reporter)

Updated

18 years ago
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

18 years ago
I fixed this along with other editor-related work in the global UI area.
The "Cancel" button was moved to the last (4th) position in the
platformDialogOverlay.xul file for Windows only, as described in previous
comments.

Updated

18 years ago
Status: RESOLVED → VERIFIED

Comment 9

18 years ago
Seems fine, 1999101508 build, NT. (Verified using profile manager.)
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.