Closed
Bug 1473585
Opened 6 years ago
Closed 6 years ago
Remove restoreLastSession function
Categories
(Firefox :: General, enhancement, P3)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: dao, Assigned: manishkk, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
|
1.63 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Let's remove this function: https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/browser/base/content/browser.js#7813-7816 and directly call SessionStore.restoreLastSession() instead of restoreLastSession(): https://searchfox.org/mozilla-central/rev/6ef785903fee6c0b16a1eab79d722373d940fd78/browser/base/content/browser-sets.inc#93
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
|
|
Assignee | |
Comment 1•6 years ago
|
||
Please review. Thanks
Attachment #8990525 -
Flags: review?(dao+bmo)
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 8990525 [details] [diff] [review] Patch_Bug1473585 Thanks!
Attachment #8990525 -
Flags: review?(dao+bmo) → review+
|
||
Comment 3•6 years ago
|
||
Has this bug been fixed? If not can I try this bug? I am new to open source. I would be glad for some pointers. Thanks!
|
|
Assignee | |
Comment 4•6 years ago
|
||
Hi Mihir! yes, I already submitted the patch. You can look for unassigned Good-first-bug here- https://www.joshmatthews.net/bugsahoy/?unowned=1&simple=1
|
|
||
Comment 5•6 years ago
|
||
Thanks I'll check them out!
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8bcdfbe1d0dc Remove restoreLastSession function. r=dao
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8bcdfbe1d0dc
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•