Closed Bug 1473607 Opened 7 years ago Closed 7 years ago

Add a test for clearing downloads from the library window

Categories

(Firefox :: Downloads Panel, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

Working on bug 1468980 I discovered there was no test for clearing downloads via the library window. Hence adding one as I'm changing some code in that area. Note: it seemed easier to add a download via drag and drop to get the test set up correctly, so I've shared some of the code across the other tests.
Attached patch Patch updates (obsolete) — Splinter Review
Apparently the issue was that children.length always returned zero. Observing the childList seems to work, even if the code might remove the richlistbox from the document and re-add it. This patch should fix the issue and a few nits.
Flags: needinfo?(standard8)
(In reply to :Paolo Amadini from comment #3) > Apparently the issue was that children.length always returned zero. > Observing the childList seems to work, even if the code might remove the > richlistbox from the document and re-add it. This patch should fix the issue > and a few nits. Thank you for taking a look at this. I was fairly sure I'd already tried it just like you have it, but maybe I did something wrong and didn't notice. I've combined the patches and done a try push here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c114cc5f31591a69c8c9077948fb8c72486a1e2 Thanks again.
Flags: needinfo?(standard8)
Attachment #8990723 - Attachment is obsolete: true
Comment on attachment 8990035 [details] Bug 1473607 - Add a test for clearing all downloads via the Library window commands. :Paolo Amadini has approved the revision. https://phabricator.services.mozilla.com/D1973
Attachment #8990035 - Flags: review+
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edaeac215135 Add a test for clearing all downloads via the Library window commands. r=paolo
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: