Closed Bug 1473672 Opened 8 years ago Closed 6 years ago

Intermittent devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js | The current time of '.div1' animation is 50% - Got 49999.99999900001, expected 50000

Categories

(DevTools :: Inspector, defect, P5)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Assigned: abhi)

References

Details

(Keywords: good-first-bug, intermittent-failure, Whiteboard: [TV-bf pass:pass])

Filed by: nerli [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=186664876&repo=mozilla-central https://queue.taskcluster.net/v1/task/Ga7862TmT7OFyeUxjZ4eVQ/runs/0/artifacts/public/logs/live_backing.log [task 2018-07-05T17:09:45.830Z] INFO - TEST-START | devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js [task 2018-07-05T17:09:47.248Z] INFO - GECKO(1018) | console.log: "[DISPATCH]" [task 2018-07-05T17:09:47.304Z] INFO - GECKO(1018) | console.log: "[DISPATCH]" "{\n \"type\": \"UPDATE_SIDEBAR_SIZE\",\n \"sidebarSize\": null\n}" [task 2018-07-05T17:09:47.507Z] INFO - GECKO(1018) | console.log: "[DISPATCH]" [task 2018-07-05T17:09:47.629Z] INFO - GECKO(1018) | console.log: "[DISPATCH]" [task 2018-07-05T17:09:47.715Z] INFO - GECKO(1018) | console.log: "[DISPATCH]" [task 2018-07-05T17:09:47.980Z] INFO - GECKO(1018) | console.log: "[DISPATCH]" [task 2018-07-05T17:09:48.057Z] INFO - GECKO(1018) | console.log: "[DISPATCH]" [task 2018-07-05T17:09:48.135Z] INFO - TEST-INFO | started process screentopng [task 2018-07-05T17:09:48.586Z] INFO - TEST-INFO | screentopng: exit 0 [task 2018-07-05T17:09:48.588Z] INFO - Buffered messages logged at 17:09:45 [task 2018-07-05T17:09:48.589Z] INFO - Entering test bound [task 2018-07-05T17:09:48.590Z] INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/inspector/animation/test/doc_custom_playback_rate.html [task 2018-07-05T17:09:48.591Z] INFO - Tab added and finished loading [task 2018-07-05T17:09:48.592Z] INFO - Loading the helper frame script chrome://mochitests/content/browser/devtools/client/inspector/animation/test/doc_frame_script.js [task 2018-07-05T17:09:48.593Z] INFO - Loading the helper frame script chrome://mochitests/content/browser/devtools/client/shared/test/frame-script-utils.js [task 2018-07-05T17:09:48.594Z] INFO - Opening the inspector [task 2018-07-05T17:09:48.595Z] INFO - Opening the toolbox [task 2018-07-05T17:09:48.596Z] INFO - Buffered messages logged at 17:09:47 [task 2018-07-05T17:09:48.597Z] INFO - Toolbox opened and focused [task 2018-07-05T17:09:48.598Z] INFO - Selecting the newanimationinspector sidebar [task 2018-07-05T17:09:48.599Z] INFO - Pause the all animation and set current time to middle time in order to check the adjusting time [task 2018-07-05T17:09:48.600Z] INFO - Click on pause/resume button [task 2018-07-05T17:09:48.601Z] INFO - Click 70 on scrubber controller [task 2018-07-05T17:09:48.602Z] INFO - Check the created times of all animation are same [task 2018-07-05T17:09:48.603Z] INFO - TEST-PASS | devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js | Adjusted time is correct - [task 2018-07-05T17:09:48.604Z] INFO - Change the current time to 75% after selecting '.div2' [task 2018-07-05T17:09:48.605Z] INFO - Selecting the node for '.div2' [task 2018-07-05T17:09:48.606Z] INFO - Click 105 on scrubber controller [task 2018-07-05T17:09:48.607Z] INFO - Buffered messages logged at 17:09:48 [task 2018-07-05T17:09:48.608Z] INFO - Check each adjusted result of animations after selecting 'body' again [task 2018-07-05T17:09:48.609Z] INFO - Selecting the node for 'body' [task 2018-07-05T17:09:48.610Z] INFO - TEST-PASS | devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js | Adjusted time is correct - [task 2018-07-05T17:09:48.610Z] INFO - Buffered messages finished [task 2018-07-05T17:09:48.611Z] INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js | The current time of '.div1' animation is 50% - Got 49999.99999900001, expected 50000 [task 2018-07-05T17:09:48.612Z] INFO - Stack trace: [task 2018-07-05T17:09:48.612Z] INFO - chrome://mochikit/content/browser-test.js:test_is:1300 [task 2018-07-05T17:09:48.613Z] INFO - chrome://mochitests/content/browser/devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js:null:30 [task 2018-07-05T17:09:48.614Z] INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1098 [task 2018-07-05T17:09:48.614Z] INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1089 [task 2018-07-05T17:09:48.615Z] INFO - chrome://mochikit/content/browser-test.js:nextTest/<:991 [task 2018-07-05T17:09:48.615Z] INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795 [task 2018-07-05T17:09:48.616Z] INFO - TEST-PASS | devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js | The current time of '.div2' animation is 75% - [task 2018-07-05T17:09:48.617Z] INFO - Leaving test bound [task 2018-07-05T17:09:48.909Z] INFO - Removing tab. [task 2018-07-05T17:09:48.910Z] INFO - Waiting for event: 'TabClose' on [object XULElement]. [task 2018-07-05T17:09:48.926Z] INFO - Got event: 'TabClose' on [object XULElement]. [task 2018-07-05T17:09:48.935Z] INFO - Tab removed and finished closing [task 2018-07-05T17:09:48.963Z] INFO - GECKO(1018) | MEMORY STAT | vsize 2462MB | residentFast 557MB | heapAllocated 232MB [task 2018-07-05T17:09:48.970Z] INFO - TEST-OK | devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js | took 3135ms [task 2018-07-05T17:09:49.007Z] INFO - checking window state

Looks like something that could be fixed by rounding the number we get.

Keywords: good-first-bug

Hey, I would like to work on it. Can you please assign it to me?

Hello Paarmita.
It looks like you're assigned on 6 bugs at the moment.
Before taking anything new, it would be better if you finish those.
Also, you already fixed a few good-first-bugs, and we want to keep them for the actual first bug of new contributors :)

Hey Nicolas,
Can you kindly assign it to me and help me in getting started with this bug?
[If no one is working on it yet]

Hello abhi, thanks for offering help!
I assigned the bug to you.

So, the problem lies in this assertion devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js#30-31.
Sometimes, animationInspector.state.animations[0].state.currentTime is 49999.99999900001 instead of 50000.
As you can see, it's pretty close, and we shouldn't fail the test for that.
So the goal here would be to round animationInspector.state.animations[0].state.currentTime (so in this case, it would round to the expected value).

You can run the test by doing mach test devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js.
I suggest you to add the --headless option so it runs in the background.
Finally, you can add --verify to run the test multiple times.

So it should look like mach test devtools/client/inspector/animation/test/browser_animation_logic_adjust-time.js --headless --verify.

If you don't have setup the work environment yet, you can follow http://docs.firefox-dev.tools/getting-started/. Make sure to choose Artifact builds when asked to, as it's much faster to work with those.

Don't hesitate to ask any question, either here or on Slack.

Assignee: nobody → abhi.aecs
Status: NEW → ASSIGNED

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
See Also: → 1583232
You need to log in before you can comment on or make changes to this bug.