Closed Bug 1473713 Opened Last year Closed Last year

GeckoSession.saveState() is broken when a11y enabled

Categories

(GeckoView :: General, defect)

59 Branch
defect
Not set

Tracking

(firefox62 fixed, firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: snorp, Assigned: snorp)

Details

Attachments

(1 file)

I wrote a test for GeckoSession.saveState() in bug 1468048, and noticed recently it started failing if the a11y tests were run before it. It turns out that something in a11y loads a Utils.jsm into the content script namespace, which conflicts with the Utils.jsm in GeckoViewContent.js. This causes saveState() to blow up when it tries to use Utils.mapFrameTree().
Assignee: nobody → snorp
Comment on attachment 8990105 [details]
Bug 1473713 - Fix GeckoSession.saveState() when accessibility is used

https://reviewboard.mozilla.org/r/255106/#review262188

r+ with nit.

::: mobile/android/chrome/geckoview/GeckoViewContent.js:15
(Diff revision 1)
>    Services: "resource://gre/modules/Services.jsm",
>    SessionHistory: "resource://gre/modules/sessionstore/SessionHistory.jsm",
>    FormData: "resource://gre/modules/FormData.jsm",
>    PrivacyFilter: "resource://gre/modules/sessionstore/PrivacyFilter.jsm",
>    ScrollPosition: "resource://gre/modules/ScrollPosition.jsm",
>    Utils: "resource://gre/modules/sessionstore/Utils.jsm",

Surely you should remove this import of sessionstore/Utils.jsm?
Attachment #8990105 - Flags: review?(droeh) → review+
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ff3ec32b2dc
Fix GeckoSession.saveState() when accessibility is used r=droeh
https://hg.mozilla.org/mozilla-central/rev/1ff3ec32b2dc
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Comment on attachment 8990105 [details]
Bug 1473713 - Fix GeckoSession.saveState() when accessibility is used

Approval Request Comment
[Feature/Bug causing the regression]: GeckoView
[User impact if declined]: GeckoSession.saveState() can hang, resulting in ANRs in apps
[Is this code covered by automated tests?]: Yes, gv-junit
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No 
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only affects GV
[String changes made/needed]: None
Attachment #8990105 - Flags: approval-mozilla-beta?
Comment on attachment 8990105 [details]
Bug 1473713 - Fix GeckoSession.saveState() when accessibility is used

Geckoview-only fix, let's uplift for beta 9.
Attachment #8990105 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Firefox for Android → GeckoView
Version: Firefox 59 → 59 Branch
Target Milestone: Firefox 63 → mozilla63
You need to log in before you can comment on or make changes to this bug.