Closed Bug 1473717 Opened Last year Closed Last year

Update Debugger Frontend v69

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch 69-1.patch (obsolete) — Splinter Review
Attachment #8990112 - Flags: review?(jdescottes)
√ readme
√ git log - relevant dirs don't show any overwriting commits
√ commit message

unusual file changes
√ test changes - needed for sources.get
√ jar.mn - we're adding two new svgs
√ moz.build - we're adding a new telemetry helper
Attached patch 69-2.patchSplinter Review
Attachment #8990112 - Attachment is obsolete: true
Attachment #8990112 - Flags: review?(jdescottes)
Attachment #8990152 - Flags: review?(jdescottes)
Assignee: nobody → jlaster
Severity: normal → enhancement
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8990152 [details] [diff] [review]
69-2.patch

Review of attachment 8990152 [details] [diff] [review]:
-----------------------------------------------------------------

OK with sync from https://bugzilla.mozilla.org/show_bug.cgi?id=1446760

::: devtools/client/debugger/new/test/mochitest/browser.ini
@@ +228,5 @@
>  skip-if = os == 'linux' && !asan # bug 1447118
>  [browser_dbg-sources.js]
>  [browser_dbg-sources-named-eval.js]
>  [browser_dbg-stepping.js]
> +skip-if = debug || (verify && (os == 'win'))

Missing sync https://bugzilla.mozilla.org/show_bug.cgi?id=1446760
Attachment #8990152 - Flags: review?(jdescottes) → review+
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb4f7d4ea5b3
Update Debugger Frontend v69. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/eb4f7d4ea5b3
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.