1473739 - VM Fails to build debug

Status: NEW

(Firefox Build System :: General, defect)

Description

[TimeHorse]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180607194748

Steps to reproduce:

Follow the instructions at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Using_the_VM to download the development VM, then, once started, the Sublime development window comes up (you might have to reboot the VM to get the settings for the development environment to configure).  In Sublime, select the menu item "Tools"->"Build System"->"Firefox (Debug)", then select "Tools"->"Build".  This will fail with the error below.  Note, building "Firefox (Opt)" succeeds.


Actual results:

 0:00.14 /usr/bin/make -f client.mk -s
 0:00.67 Adding client.mk options from /home/firefox-dev/mozilla-central/.mozconfig-debug:
 0:00.67     MOZ_CO_PROJECT=browser
 0:00.67     AUTOCLOBBER=1
 0:00.67     MOZ_OBJDIR=/home/firefox-dev/mozilla-central/objdir-frontend-debug
 0:00.67     OBJDIR=/home/firefox-dev/mozilla-central/objdir-frontend-debug
 0:00.67     FOUND_MOZCONFIG=/home/firefox-dev/mozilla-central/.mozconfig-debug
 0:01.37 Attempting to find a pushhead containing e64d2a4451d6a226791b88b72e257787c2536f1f on mozilla-central.
 0:01.37 Attempting to find a pushhead containing e64d2a4451d6a226791b88b72e257787c2536f1f on integration/mozilla-inbound.
 0:01.37 Attempting to find a pushhead containing e64d2a4451d6a226791b88b72e257787c2536f1f on releases/mozilla-aurora.
 0:01.37 Retrieving the last 50 pushheads starting with id 10863 on releases/mozilla-aurora
 0:01.37 Retrieving the last 50 pushheads starting with id 86275 on integration/mozilla-inbound
 0:01.37 Retrieving the last 50 pushheads starting with id 31273 on mozilla-central
 0:01.87 Tried 2 pushheads, no built artifacts found.
 0:01.91 Makefile:233: recipe for target 'recurse_artifact' failed
 0:01.91 make[4]: *** [recurse_artifact] Error 1
 0:01.91 /home/firefox-dev/mozilla-central/config/recurse.mk:32: recipe for target 'artifact' failed
 0:01.91 make[3]: *** [artifact] Error 2
 0:01.91 /home/firefox-dev/mozilla-central/config/rules.mk:522: recipe for target 'default' failed
 0:01.91 make[2]: *** [default] Error 2
 0:01.91 /home/firefox-dev/mozilla-central/client.mk:419: recipe for target 'realbuild' failed
 0:01.91 make[1]: *** [realbuild] Error 2
 0:01.91 client.mk:170: recipe for target 'build' failed
 0:01.91 make: *** [build] Error 2
 0:01.92 0 compiler warnings present.
[Finished in 2.0s with exit code 2]


Expected results:

The pre-configured system should compile out of the box.  That's the point of the pre-configured system.

Comment 1

[David Olah]

Hi,

I tried to reproduce the issue, but after Downloading the .ova file, this error message is showing: Could not open "FirefoxBuildEnv.ova"

Comment 2

[TimeHorse]

When I updated to the latest via hg I still couldn't build the Debug though I found in mozilla-central/xpfe/.mozconfig-debug, if you comment out "#ac_add_options --disable-optimize" it compiles just fine.  I believe this setting is deprecated and should be remove from the current build.

Comment 3

[David Olah]

Thank you for the update!

I will set Build config component to this issue, regarding the fact that I don't have too much experience with these kind of issues.

Comment 4

[Mike Hommey [:glandium]]

> 0:01.37 Attempting to find a pushhead containing e64d2a4451d6a226791b88b72e257787c2536f1f on mozilla-central.
> 0:01.37 Attempting to find a pushhead containing e64d2a4451d6a226791b88b72e257787c2536f1f on integration/mozilla-inbound.
> 0:01.37 Attempting to find a pushhead containing e64d2a4451d6a226791b88b72e257787c2536f1f on releases/mozilla-aurora.

e64d2a4451d6a226791b88b72e257787c2536f1f is about 1.5 years old. You can't do an artifact build with a tree that old. I guess the VM hasn't been updated in a while. I didn't even know that existed. 

The instructions should probably move https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Using_the_VM#Working_in_the_VM before https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Using_the_VM#Building_Firefox

Anyways, digging in the history of the MDN page, the VM was created and updated by ttaubert, and he recently left, so he won't be updating it...

Not sure whose umbrella that would fall under, now.

One might consider it superseded by janitor https://janitor.technology/ although that doesn't give local VMs.

Greg, thoughts?

Comment 5

[Gregory Szorc [:gps]]

I'm raking the cobwebs in my brain trying to remember if I even know about this VM. Maybe at one time. But it certainly isn't on my radar today. And I can say with near certainty that build peers don't maintain it.

Since the docs on MDN were written, containers - notably Docker - have taken off. I think the future of Firefox development looks more like "bring a container to a VM" than "use a VM." I'm tempted to say the VM docs should be nuked because they are old and refer to an unmaintained system. I'd rather steer people towards "start with a fresh install of distro X and run the one-line bootstrapper to configure your system" or "use Janitor" instead. (Although I'm not sure if we ever made Janitor turnkey enough for new contributors and am not sure if it is actively supported.)

Setting needinfo on mhoye in case the community manager wishes to weigh in.