1473754 - Port bug 1452706 - Make the 'expected' argument to Assert.throws/rejects required rather than optional

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

After landing of bug 1452706 some tests fail:
TEST-UNEXPECTED-FAIL | comm/mailnews/mime/jsmime/test/test_custom_headers.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | comm/mailnews/mime/jsmime/test/test_header_emitter.js | xpcshell return code: 0

https://taskcluster-artifacts.net/Im_fSMBGQPCDoldXjU-REQ/0/public/logs/live_backing.log
says:
Unexpected exception AssertionError: Error: The 'expected' argument was not supplied to Assert.throws()

And sure enough, we use assert.throws() in those two tests and nowhere else in C-C:
https://dxr.mozilla.org/comm-central/search?q=assert.throws&redirect=false

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1473754-assert-throws.patch

This does the trick.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a2edf68a0bf2
Port bug 1452706: Add 'expected' argument to Assert.throws. rs=bustage-fix DONTBUILD

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8990157 [details] [diff] [review]
1473754-assert-throws.patch

I was surprised that
assert.throws(function () { emitter.addDate(new Date("10000-01-01")); }, /Cannot encode an invalid date/);
throws "cannot encode" instead of "out of range". Maybe something already goes wrong in |new Date("10000-01-01")| like in |new Date(NaN)|. Anyway, this is "bustage fix", so if we care, we need to follow up in another bug.

Comment 4

[:aceman]

Comment on attachment 8990157 [details] [diff] [review]
1473754-assert-throws.patch

Review of attachment 8990157 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!