1473795 - Show warnings and blockers after user shows intent to land

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[Israel Madueme [:imadueme]]

Lando UI does a landing dryrun when you load the page to so that it can immediately show you any problems you may encounter. While this is nice, it does cause confusion; e.g. when you load the page just to check the status and you see a big red blocker at the bottom, or when you've landed something and see a bunch of warnings about landing it again.

Instead:

- If the user isn't logged in, we can show a even lighter subtle notice that you need to log in first to land something.

- If the user is logged in, we should show the big green Land button as though there were no warnings or blockers. If they want to land it, they will inevitably click that button.

- If the user doesn't click that button, great! They didn't want to even land the revision.

- If the user does click the button, then we will display the warnings or blockers on the UI and also change the status of the Land button to represent that (e.g. disabled and red if there's a blocker, or yellow until all warnings are checked if there are warnings). If there are no warnings, we will display a green box that says it's clear to land or something to that effect.

- In the case that there are no warnings/blockers or if all warnings are checked, the Land button will turn into a 'Confirm' button which will initiate the landing when clicked. This means that all landings will require at least 2 clicks, preventing accidental landings which is very easy to do right now (the Land button is pretty big and tempting...).

- In the future we can perform the dryrun only when the Land button is clicked, but, for the sake of simplicity I think it is best to just have it prerendered by the server and hidden until needed. The user can refresh the page to update the state. When we do move the query to the client on button click, we should make sure that the revision state displayed matches the dryrun state.

Comment 1

[Israel Madueme [:imadueme]]

We can also prefix the warnings / blockers sections to describe what they are (e.g. these are warnings, notice them, but, you can bypass them...these are blockers, they're stopping you from landing).

Also a tip to refresh the page to update the state.

Comment 2

[Israel Madueme [:imadueme]]

Attachment: revisions: improve user experience of landing (Bug 1473795)

Prior to this commit, all the warnings and blockers would appear
on page load; e.g. when users just loaded the page and didn't even
intend on landing it, when they are viewing a revision that already
landed in the past, and so on.

Rather than give users this info when they may not need it, we now
display the warnings and blockers only after the user clicks the land
button. This gives the user context - that these messages are related
to their attempt to land the revision.

They can click the land button again to follow through with landing
(assuming no blockers, warnings are checked, etc.)

Comment 3

[Israel Madueme [:imadueme]]

Attachment: Lando-better-landing-flow.mp4

Comment 4

[Phabricator Automation]

Comment on attachment 8991303 [details]
revisions: improve user experience of landing (Bug 1473795)

Māris Fogels [:mars] has approved the revision.

https://phabricator.services.mozilla.com/D2070